Added image and snapshot metrics #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 6, 2015 14:55
|
I find your lack of tests disturbing~ |
|
Does what is currently there seem sane though? (yet to add folds + tests + pollster format) |
|
This looks fine to me, pending tests. |
|
merge with magikarp, it's changed since you forked |
|
Adding in some tests I missed also |
|
any hard-coded source dict key/vals should be moved to Tags |
added 8 commits
February 9, 2015 14:03
Conflicts: lib/Ceilometer/Infer.hs
| $(makeLenses ''PDImage) | ||
|
|
||
| newtype PDImageP = PDImageP { _pdImagePVal :: PFValue64 } | ||
| deriving (Show, Read, Eq, Typeable) |
There was a problem hiding this comment.
what's ImageP? ImagePoint? sounds a bit like ImagePipe
There was a problem hiding this comment.
should I s/ImageP/ImagePollster/g ?
There was a problem hiding this comment.
probably, we tend to append "P" for pipe versions of stuff
|
I haven't checked, but cleans & rebuilds to make sure we have no warnings |
|
Succeeded by #5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Image Events and Pollsters
Added Snapshot Events
Updated Infer.hs for instance_disk
Fixed some prism bugs
Added missing tests
@tranma