feat: release on windows #22
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Will Murphy <will.murphy@anchore.com>
|
Something isn't working with the Windows validations: make test
shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"
env:
FORCE_COLOR: true
bash: line 1: .tool/task: No such file or directory
bash: line 1: .tool/task: No such file or directory
make: 'test' is up to date.It looks like the windows validations just didn't do anything, but still turned green (https://github.com/anchore/binny/actions/runs/9022127458/job/24790946459?pr=22#step:4:9). Maybe making the |
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
This reverts commit 342e7b0. Signed-off-by: Will Murphy <will.murphy@anchore.com>
This reverts commit 0ba0e61. Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Otherwise, for example, downloading syft.exe on windows results in a file called syft, which windows doesn't necessarily know it can execute. Signed-off-by: Will Murphy <will.murphy@anchore.com>
Moving another shell utility to a python one-liner to try to make binny's test suite work on windows. Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support windows by:
Closes #17