Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPDX JSON has external reference category of PACKAGE_MANAGER instead of PACKAGE-MANAGER #1236

Closed
ddillard opened this issue Oct 1, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@ddillard
Copy link

ddillard commented Oct 1, 2022

What happened:
Generated an SBOM in SPDX JSON format and took a look at the output and noticed it has external reference category of "PACKAGE_MANAGER".

What you expected to happen:
Per the SPDX JSON schema the value should be "PACKAGE-MANAGER", i.e. the separator should be a hyphen, not an underscore.

How to reproduce it (as minimally and precisely as possible):
Just run syft against a container and generate an SBOM in SPDX JSON format.

Anything else we need to know?:
Don't think so.

Environment:

  • Output of syft version:
    0.58.0

  • OS (e.g: cat /etc/os-release or similar):
    Ubuntu 10.04.6 LTS

@ddillard ddillard added the bug Something isn't working label Oct 1, 2022
@ddillard
Copy link
Author

ddillard commented Oct 2, 2022

Turns out this may be due to an inadvertent update in the JSON schema, see this.

@spiffcs
Copy link
Contributor

spiffcs commented Oct 3, 2022

We'll keep an eye on where it goes on that issue and what they decide. Great find thanks for the issue @ddillard!

Is this currently throwing any errors of compatibility on your end with this inadvertent update?

@ddillard
Copy link
Author

ddillard commented Oct 3, 2022

No, this isn't causing me any issues the moment. I was just doing some testing and noticed the discrepancy. If the proposed fix is implemented no changes will be required in syft, though I do believe grype might need a minor update.

@ddillard
Copy link
Author

ddillard commented Oct 5, 2022

Both are going to be supported so no issue for SBOM generation.

@ddillard ddillard closed this as not planned Won't fix, can't repro, duplicate, stale Oct 5, 2022
@kzantow
Copy link
Contributor

kzantow commented Feb 22, 2023

Just a note: there was a request to undo this change: #1596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants