Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DependencyManagement ignored in pom.xml #1813

Open
cjnosal opened this issue May 11, 2023 · 3 comments · May be fixed by #2669 or #2769
Open

DependencyManagement ignored in pom.xml #1813

cjnosal opened this issue May 11, 2023 · 3 comments · May be fixed by #2669 or #2769
Labels
bug Something isn't working

Comments

@cjnosal
Copy link

cjnosal commented May 11, 2023

What happened:
Ran a directory scan containing an effective-pom on a spring boot project. Only 4 results (from the top-level <dependencies>) were returned.

What you expected to happen:
All dependencies at the root level and transitive dependencies nested in <dependencyManagement> to be present in syft output

Steps to reproduce the issue:

git clone https://github.com/sample-accelerators/tanzu-java-web-app
cd tanzu-java-web-app
./mvnw help:effective-pom -Doutput results/pom.xml
syft dir:results

Anything else we need to know?:

Environment:

  • Output of syft version: 0.75.0
  • OS (e.g: cat /etc/os-release or similar): ubuntu 20.04.6
@cjnosal cjnosal added the bug Something isn't working label May 11, 2023
@tgerla
Copy link
Contributor

tgerla commented Jun 15, 2023

Hi @xtreme-conor-nosal, thanks for filing the issue, we will go ahead and put this in the backlog for a fix when we are able.

@kzantow
Copy link
Contributor

kzantow commented Jun 15, 2023

Developer notes: there are 2 main issues here:

  1. Syft does not download additional pom.xml information (e.g. parent POMs, transitive dependency POMs)
  2. Syft does not honor the dependencyManagement section

Within the same POM, Syft should still honor dependencyManagement, which essentially are dependency groupId, artifactId, and version, where if a dependency appears in the dependency section without a version, it should be inferred from the dependencyManagement section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
3 participants