Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove internal.StringSet #2209

Closed
wagoodman opened this issue Oct 10, 2023 · 0 comments · Fixed by #2219
Closed

Remove internal.StringSet #2209

wagoodman opened this issue Oct 10, 2023 · 0 comments · Fixed by #2219
Assignees
@wagoodman
Labels
bug Something isn't working
Milestone
Syft v1.0.0

Comments

@wagoodman
Copy link
Contributor

Today we have internal.StringSet which is exposed on the pkg.License (the URLs field). This type should be swapped out with one that is accessible to others since the license object is a core object. Ideally we would replace all instances of the internal string set entirely.
@wagoodman wagoodman added the bug Something isn't working label Oct 10, 2023
@wagoodman wagoodman added this to the Syft 1.0 milestone Oct 10, 2023
@wagoodman wagoodman self-assigned this Oct 11, 2023
@wagoodman wagoodman mentioned this issue Oct 11, 2023
Merged
@chenrui333 chenrui333 mentioned this issue Oct 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wagoodman wagoodman

Labels
bug Something isn't working
Projects
None yet
Milestone
Syft v1.0.0
Development

Successfully merging a pull request may close this issue.

Remove internal string set anchore/syft
1 participant
@wagoodman