Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cataloging python packages errors out if "top_level.txt" entry is missing #259

Closed
wagoodman opened this issue Nov 10, 2020 · 3 comments · Fixed by #260
Closed

Cataloging python packages errors out if "top_level.txt" entry is missing #259

wagoodman opened this issue Nov 10, 2020 · 3 comments · Fixed by #260
Labels
bug Something isn't working

Comments

@wagoodman
Copy link
Contributor

What happened:
As reported by Wagde Zabit

[0250] ERROR failed to catalog: 1 error occurred:
	* unable to catalog python package=/usr/local/lib/python3.8/site-packages/ptyprocess-0.6.0.dist-info/METADATA: missing python package top_level.txt (package="/usr/local/lib/python3.8/site-packages/ptyprocess-0.6.0.dist-info/METADATA"

What you expected to happen:
Cataloging should have continued to conclusion with results instead of stopping

Environment:
This was discovered with grype v0.3.0

Notes
This is where the problem is

if topLevelRef == nil {
return nil, nil, fmt.Errorf("missing python package top_level.txt (package=%q)", string(metadataRef.Path))
}
, and should probably only be a log statement instead of returning an error (a best-effort strategy).

@wagoodman wagoodman added the bug Something isn't working label Nov 10, 2020
@wagde-orca
Copy link

is it fixed in grype or not yet?

@luhring
Copy link
Contributor

luhring commented Nov 12, 2020

@wagde-orca We're actually working on that right this second! We fixed one more thing in Syft, and then will update Grype to include the fix.

@luhring
Copy link
Contributor

luhring commented Nov 12, 2020

@wagde-orca Hi there, we just released grype v0.4.0 which should resolve this issue. Let us know if you have any trouble!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants