Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relationships / Dependencies are present in Syft json and SPDX json files but sometimes not in Cyclonedx json file format #2832

Open
haiazuki opened this issue May 2, 2024 · 7 comments
Labels
bug Something isn't working ecosystem:java relating to the java ecosystem

Comments

@haiazuki
Copy link

haiazuki commented May 2, 2024

What happened:
I am not seeing dependencies information on CycloneDX format json files even though they are present in other formats:

SPDX file snippet:

   "relationships": [
        {
            "comment": "evident-by: indicates the package's existence is evident by the given file",
            "relatedSpdxElement": "SPDXRef-File--Install-LMFIN-10010154-001574.jar-39b2fbb066459eaa",
            "relationshipType": "OTHER",
            "spdxElementId": "SPDXRef-Package-java-archive-org.eclipse.osgi-0988631922bb71dc"
        },
        {
            "comment": "evident-by: indicates the package's existence is evident by the given file",
            "relatedSpdxElement": "SPDXRef-File--Install-LMFIN-10010154-001574.jar-39b2fbb066459eaa",
            "relationshipType": "OTHER",
            "spdxElementId": "SPDXRef-Package-java-archive-org.eclipse.equinox.http.servletbridge-1.0.100.v20090520-0fa41529ebc92c19"
        },
        {
            "relatedSpdxElement": "SPDXRef-Package-java-archive-defaultHelp-25eed61145441535",
            "relationshipType": "CONTAINS",
            "spdxElementId": "SPDXRef-DocumentRoot-File-Install-LMFIN-10010154-001574.jar"
        },
        {
            "relatedSpdxElement": "SPDXRef-Package-java-archive-el-4ab927d37eec02be",
            "relationshipType": "CONTAINS",
            "spdxElementId": "SPDXRef-DocumentRoot-File-Install-LMFIN-10010154-001574.jar"
        },

What you expected to happen:
Dependencies should appear in the Cyclonedx format json file similar to SPDX and Syft json files.

Steps to reproduce the issue:
I tried generating SBOM file in CycloneDX format and noticed that no dependencies are included in the sbom file. But then I tried generating an SBOM in Syft json and SPDX json formats and see that relationships / dependencies information are present. I tried converting the SBOM to CycloneDX format and no dependencies information are included in the output.

Anything else we need to know?:
N/A

Environment:

  • Output of syft version:
    Application: syft
    Version: 1.2.0
    BuildDate: 2024-04-12T18:31:58Z
    GitCommit: dde5d34
    GitDescription: v1.2.0
    Platform: windows/amd64
    GoVersion: go1.21.9
    Compiler: gc

  • OS (e.g: cat /etc/os-release or similar):
    Windows 11 Enterprise

@haiazuki haiazuki added the bug Something isn't working label May 2, 2024
@tgerla
Copy link
Contributor

tgerla commented May 2, 2024

Thanks @haiazuki for the report! We will take a look. This issue is possibly related to: #2353 and #2305

@tgerla
Copy link
Contributor

tgerla commented May 2, 2024

Dev notes: there are some format limitations in CycloneDX that prevent us from representing every relationship that we handle in other formats like SPDX, so there will always be some functionality differences between the various formats. We could probably encode CONTAINS and DEPENDS-ON relationships in CycloneDX, though. The challenge encoding the CONTAINS relationship is that it requires nesting components in CycloneDX which we aren't currently doing--it wouldn't be expressible in the dependency relationships.

@haiazuki, if you are able, can you share a bit more about your use case and needs here? Are you looking for a source code dependency tree or something similar? More details might be helpful for us to look into this. Thanks!

@haiazuki
Copy link
Author

haiazuki commented May 3, 2024

Hi @tgerla ,
I checked the specifications of SPDX compare with CycloneDX so I understand what you are saying. From a CycloneDX perspective, it tracks dependency relationships so DEPENDS-ON seem to be the priority.
In the product I am testing with, I have an installer in a jar package that I used as the target source to generate the sbom. This contains other jar files and also a war file that contains other jar file packages. So I was looking for entries that reflect the relationship of these packages similar to what is in default json and spdx json.

Thank you!

@spiffcs spiffcs added the ecosystem:java relating to the java ecosystem label May 16, 2024
@flemminglau
Copy link

flemminglau commented Jun 5, 2024

I see syft producing usable Cyclonedx dependency information for image scans except from the tiny detail described here: DependencyTrack/dependency-track#3314

I have tried manually adding the missing dependency between the root object and some random set of modules and then DT can show a dependency tree for that part. It seems DT doesn't even try to build a dependency tree when the root dependency is missing. Probably because it doesn't know where to start.

Is there a good reason this has not been fixed already (or why the issue has ever arisen)?

@haiazuki
Copy link
Author

Shouldn't this need to be included in milestone "Meet NTIA Minimum SBOM Requirements" as relationships are part of the minimum elements in NTIA?

@spiffcs spiffcs changed the title Relationships / Dependencies are present in Syft json and SPDX json files but not in Cyclonedx json file format Relationships / Dependencies are present in Syft json and SPDX json files but sometimes not in Cyclonedx json file format Jun 13, 2024
@spiffcs
Copy link
Contributor

spiffcs commented Jun 13, 2024

👋 I think it would be useful for this issue if we could posting specific examples of where dependencies should exist in cyclone-dx and they are not showing up. Syft currently uses the dependencies field of cyclone dx to represent depends-on as found by spdx.

Are there other sections we should be putting non dependency relationship information?
In the SBOM you are generating what data is not showing up in the cyclonedx dependencies section that you expect to show up?

A good example of the format I'm looking for to help the discussion is something like this:

I am using syft v1.6.0 to scan `alpine:latest`

Here are the commands I'm running:

 syft -o spdx-json alpine:latest | jq . > spdx.json
 syft -o cyclonedx-json alpine:latest | jq . > cdx.json

In spdx.json I see:

    {
      "spdxElementId": "SPDXRef-Package-apk-musl-03e521237cbed45a",
      "relatedSpdxElement": "SPDXRef-File-lib-ld-musl-aarch64.so.1-15ac5a87021c605c",
      "relationshipType": "CONTAINS"
    },

These contains relationships are not shown in cyclone-dx.

All I see in cyclone-dx are the depends on relationships - here is an example:

    {
      "ref": "pkg:apk/alpine/libcrypto3@3.3.0-r2?arch=aarch64&upstream=openssl&distro=alpine-3.20.0&package-id=0cfcda1a242dfd13",
      "dependsOn": [
        "pkg:apk/alpine/musl@1.2.5-r0?arch=aarch64&distro=alpine-3.20.0&package-id=03e521237cbed45a"
      ]
    },

@haiazuki
Copy link
Author

Hi @spiffcs,
So, to confirm, you are saying if there are depends on relationships found in SPDX format, those should be found in CycloneDX dependencies as well?
Looking at the sboms I generated for our products, I can only see CONTAINS and OTHERS type of relations on SPDX and looking at CycloneDX format, I can only see Depends on type of relationship.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ecosystem:java relating to the java ecosystem
Projects
Status: No status
Development

No branches or pull requests

4 participants