We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultipleFileContentsByRef
This was introduced/modified when writing tests assuming that MultipleFileContentsByRef didn't have a full path already. Specifically this part:
func (s DirectoryResolver) MultipleFileContentsByRef(f ...file.Reference) (map[file.Reference]string, error) { refContents := make(map[file.Reference]string) for _, fileRef := range f { resolvedPath := path.Join(s.Path, string(fileRef.Path)) _, err := os.Stat(resolvedPath) if os.IsNotExist(err) { continue } else if err != nil { log.Errorf("path (%s) is not valid: %v", resolvedPath, err) }
There shouldn't be a path.Join at all here. Tests need to be updated as well
path.Join
The text was updated successfully, but these errors were encountered:
alfredodeza
Successfully merging a pull request may close this issue.
This was introduced/modified when writing tests assuming that
MultipleFileContentsByRef
didn't have a full path already. Specifically this part:There shouldn't be a
path.Join
at all here. Tests need to be updated as wellThe text was updated successfully, but these errors were encountered: