-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a11y): technologies d'assistance #402
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13f451d
to
fb278ae
Compare
abelkhay
approved these changes
Nov 28, 2023
Mintoo200
reviewed
Dec 1, 2023
...ue-list/lieu-mediation-numerique-list-item/lieu-mediation-numerique-list-item.component.html
Outdated
Show resolved
Hide resolved
...ue-list/lieu-mediation-numerique-list-item/lieu-mediation-numerique-list-item.component.html
Outdated
Show resolved
Hide resolved
...ue-list/lieu-mediation-numerique-list-item/lieu-mediation-numerique-list-item.component.html
Outdated
Show resolved
Hide resolved
src/features/orientation/components/besoin-link/besoin-link.component.html
Outdated
Show resolved
Hide resolved
src/features/orientation/components/besoin-link/besoin-link.component.html
Outdated
Show resolved
Hide resolved
src/features/orientation/pages/disponibilite/disponibilite.page.html
Outdated
Show resolved
Hide resolved
src/features/orientation/pages/disponibilite/disponibilite.page.html
Outdated
Show resolved
Hide resolved
332f158
to
4bd6ea7
Compare
Mintoo200
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'ai mis des commentaires qui sortent peut-être du scope de cette PR qui est déjà assez longue, à vous de voir comment vous vous y prenez
src/features/adresse/components/search-field/search-field.component.html
Outdated
Show resolved
Hide resolved
...phie/components/lieux-mediation-numerique-details/accessibilite/accessibilite.component.html
Outdated
Show resolved
Hide resolved
...x-mediation-numerique-details/orientation-sheet-modal/orientation-sheet-modal.component.html
Outdated
Show resolved
Hide resolved
src/features/orientation/pages/disponibilite/disponibilite.page.html
Outdated
Show resolved
Hide resolved
c10300e
to
66c5559
Compare
LAU-MG
pushed a commit
that referenced
this pull request
Jan 9, 2024
* fix(a11y): use close icon instead of time * fix(a11y): nested buttons in orienation * fix(a11y): absolute overlap in lieux inclusion numérique list * fix(a11y): missing aria for search combobox * fix: phone number should be visible for assistive technologies * fix: alternative texts for label images should be more descriptive * fix: add missing time elements * fix: remove misuses of br tag * fix: remove help text from besoins titles * fix: remove useless button in disponibilite page * fix: remove other elements than text in h2 * fix: missing quote * fix: html syntaxe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Résout les problèmes d'accessibilité suivants :
Démo :