Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fallback for django 1.11 #8

Merged
merged 1 commit into from Apr 18, 2017
Merged

Conversation

sheeshmohsin
Copy link
Contributor

There is error when I tried to implement searchable select in django 1.11, I fixed it using the code in this pull request. Please review the code and merge it.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.0%) to 97.015% when pulling 84308dc on sheeshmohsin:master into cd00c5d on and3rson:master.

@sheeshmohsin
Copy link
Contributor Author

Hi, I am not able to detect what's failed? and also I am new to coveralls, so not sure what is decreased coverage? Can you please point me to the error or possible bugs in my code so that i can fix?

@and3rson
Copy link
Owner

@sheeshmohsin I will add info about testing coverage locally into readme in few minutes, stay tuned :)

@sheeshmohsin
Copy link
Contributor Author

Cool, Thanks

@and3rson
Copy link
Owner

and3rson commented Apr 12, 2017

@shalakhin Please check out the updated readme, I've added info on how to run tests.
Your branch should now have both checks passing once you merge master in.

@and3rson
Copy link
Owner

and3rson commented Apr 14, 2017

@sheeshmohsin any luck? Simply merging master into your branch should do the trick :)

@sheeshmohsin
Copy link
Contributor Author

@and3rson I will do by tonight (IST) after office. Thanks for the informations :)

@and3rson and3rson merged commit 84308dc into and3rson:master Apr 18, 2017
@and3rson
Copy link
Owner

I've merged it manually, waiting for the tests

@sheeshmohsin
Copy link
Contributor Author

Thanks, Apologies for the delay from my side, was bit busy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants