Skip to content
This repository has been archived by the owner on Jun 14, 2022. It is now read-only.

Some Improvements #263

Closed
malnvenshorn opened this issue Nov 24, 2018 · 4 comments
Closed

Some Improvements #263

malnvenshorn opened this issue Nov 24, 2018 · 4 comments
Assignees
Labels
Milestone

Comments

@malnvenshorn
Copy link

I'm coming from freeOTP and I noticed some aspects which I don't like about your app which prevents me from using it. Maybe my suggestions can help you to improve andOTP.

  • The first thing I've noticed is the fact that I have to set a password (keystore is not working). Yes you can argue it improves security, but it is still 2FA. If someone has your phone and access to the app he still needs your login information and if someone has your login credentials and steals your phone to generate the token he might also spend some effort in figuring out the password for andOTP. Besides that if you loose your phone you should change your passwords anyway. But maybe it's just my opinion.

  • The app is sluggish. Maybe this is related to the continuous generation of the tokens?! For example, opening the settings dialog takes ~8s on my Galaxy S5 mini. I would like an option to generate the token only if I click on the entry, like it is in freeOTP.

  • The size of the label is very small even with the lowest possible text size (12). I would suggest multiple rows or to align the icons on the right with the generated token so we have a complete line available.

I will continue watching this app, because in freeOTP I'm definitely missing the backup feature.

@flocke flocke self-assigned this Nov 24, 2018
@flocke flocke added this to the v0.7.0 milestone Nov 24, 2018
@flocke flocke added the maybe label Nov 24, 2018
@rnc
Copy link

rnc commented Dec 1, 2018

@flocke I would also like to see generate token on demand and custom images for uncommon providers (as per #225).
Unfortunately it seems Dropbox doesn't implement SAF so backup doesn't work with it although reading e.g. https://www.sitepoint.com/adding-the-dropbox-api-to-an-android-app/ it seems feasible that andOTP could potentially integrate with Dropbox?

@alerque
Copy link

alerque commented Dec 5, 2018

I'm just another end-user here, but as a place of reference I'd like to respond to your points.

  1. Keystore works for me on 3 out of 5 current devices. I have no idea why it works on some but not others, but it's quite consistent. Even changes in ROM versions haven't changed what devices keystore works on and which it doesn't.

  2. None of my devices are sluggish at all. Admittedly 2 of my 5 devices are fairly new and fast, one is still considered a mid-range devices, but two are decidedly old and underpowered. This app runs snappy on all of them, nothing has noticeable lag (I have about 35 entries). I don't think generating the keys is really that big a deal, the math involved is trivial and updating the labels on the widgets takes very little effort on the part of the device compared to much more intensive things like scrolling any view. Whatever the lag issue is it is probably not that.

  3. I'm afraid I don't follow this point. If the label is too small for you wouldn't increasing the font size make more sense? For me at least each entry already is two rows. The layout and sizing looks pretty good to me, I don't understand what the suggested improvement here would be.

@flocke
Copy link
Member

flocke commented Dec 5, 2018

I'm not gonna implement any new features in andOTP in the near future as I am rewriting the entire app from scratch, see The Rewrite. But I will think about your suggestions for the new app as soon as it is in a semi-usable state.

@flocke
Copy link
Member

flocke commented Jun 5, 2020

Closing this, since it is a very old issue and a lot has already been done to improve the raised points.

@flocke flocke closed this as completed Jun 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants