New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crashing on SSR because window is undefined #1

Closed

PeterWTipple opened this issue Mar 26, 2019 · 0 comments · Fixed by #3

PeterWTipple commented Mar 26, 2019

I am using use-smooth-scroll in a component in my shop at https://tipple.com.au

When the SSR loads, use-smooth-scroll will try to call arePassiveEventsSupported which will use window which is not defined.

Ideally this library would check if window is defined before using it, setting the result to false if it is not.

PeterWTipple mentioned this issue

Check window undefined #2

Closed

Andarist mentioned this issue

Return false on server #3

Merged

Andarist closed this as completed in #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment