Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genbooks show bookmarks from other chapters #2809

Closed
tuomas2 opened this issue Sep 2, 2023 · 0 comments
Closed

Genbooks show bookmarks from other chapters #2809

tuomas2 opened this issue Sep 2, 2023 · 0 comments

Comments

@tuomas2
Copy link
Contributor

tuomas2 commented Sep 2, 2023

  1. Open genbook at chapter 1
  2. Create bookmark in the beginning of the chapter
  3. Scroll down to chapter 2
  4. Tap beginning of chapter 2 to see (possible) bookmarks
    -> it will show bookmark from chapter 1

Bookmarks are stored to bookmarkIdsByOrdinal map based on ordinal only. It should also include key, otherwise it will cause this issue.

https://support.andbible.org/scp/tickets.php?id=2075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

1 participant