Checkpoint 4 review #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- generate the project files using django-admin - configure database and environment variables
- define custom user model extending django's - add viewsets & serializers to define user's API endpoint - update requirements.txt to cater for python3 support using pip3
- create model for images - add viewsets and serializers for endpoint - update urls.py to load uploaded images
- add Procfile for heroku deployment - update wsgi.py and requirements - add runtime.txt to specify the python version to use on deployment
- add configuration to force https on the deployed app on heroku
- allow for user to authenticate with twitter and/or instagram - configure settings to include the necessary keys and secrets
- remove email as a required field for users to work with social authentication - update viewsets and serializers to match the changes in the user models
- use django-allauth for social-account authentication using twitter - update migrations and requirements.txt
- mark items in todo - update migrations
Finish `API` backend
- add tests for api - add travis CI configuration file - update settings to use travis db when running tests
- add badges for travis CI, coveralls and quantifiedcode to the projects README.md
- add comments for classes and methods - update travis configuration to update coverage after successful build
- create django powered app - add landing page template for webapp - update setting to point to the templates directory
- include libraries under template directory - include brand on landing page, and signin button
- set dashboard view to render template - configure url for dasboard
- refactor landing and dashboard views - add tests for the landing and dashboard view - configure travis CI to check builds on branch
- implement changes to the dashbaord template - make a better favicon for project - include links on footer to make users more aware of brand
- update url for coveralls badge on readme
- render the uploded image on edit section - create service to perform image upload - refactor css to have image fit edit section
- allow for users to upload images on the image editing secton - include necessary libraries to help with file upload - update the index.html file to load libraries
user image uploading
- change templates to only load app, and require user to login if need be - fix tests for views to raise coverage - include documentation for tests to fix complains on quantifiedcode - use a bigger favicon
- add buttons to apply effects and save - work on improving coverage update on coveralls
- add buttons to apply effects to images
|
|
||
|
|
||
| def set_upload_file_path(instance, filename): | ||
| """sets upload directory for users from a derivation of their uuid""" |
There was a problem hiding this comment.
PEP8: For your docStrings, refer to this. The closing """ should be on it's own line.
- allow for users to clear image being edited - hide clear and share buttons untill there is an image
- show loading dialog for process that have a latency on slow internet connections - add event emitters for starting and finishing tasks - hide upload button after upload
- restructure the positioning of the logout button to achieve a more conventional look
- allow for users to view images they have edited
- add tests for the gallery view - remove code sections for anonymous users since all users have to be logged in
- allow for user to save an edited image - create model class, viewset and serializer for the saved image - add service to save the edited image - improve gallery template to show edited images
| @@ -0,0 +1,10 @@ | |||
| [report] | |||
| omit = | |||
| *virtualenv* | |||
There was a problem hiding this comment.
Code Quality - Nitpick
Sample review comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creates a photo editing application with the following features
Description of Task to be completed?
After reviewing the project with @andela-anandaa the following fixes were highlighted
How should this be manually tested?
To test wether these fixes have been applied, visit the hosted app on heroku here
Screenshots
Screenshot will be updated in due time