Checkpoint 1 Review #31

sundayguru · 2016-05-11T11:45:39Z

No description provided.

…cases for room

Room

Person

Room

…t case

…ss to list people

…e, I also added listallocation method to allocationapp class

…p class

…method

…hod of allocationapp class

Freezed all requirements and modified .travis.yml

Modified readme

coveralls · 2016-05-11T11:46:28Z

Changes Unknown when pulling d1f16c7 on master into * on review*.

andela-anandaa · 2016-05-11T12:50:08Z

README.md

+One stop solution for room allocation management
+
+### Badges


Move the badges to below the README title.

andela-anandaa · 2016-05-12T09:25:04Z

src/amity.py

+
+			if int(row['allocated']) > 0:
+				db.table_name = 'person'
+				people = db.execute('SELECT * FROM person WHERE assigned_room LIKE "%'+ room.name +'%"')


Code Quality: use of .format() is a cleaner way of concatenating strings that using +.

andela-anandaa · 2016-05-12T09:43:36Z

README

Your README is okay, except for a few nitpicks (in-line) above.

Github Commits

Your commit messages are not consistent, please refer to the guidelines here

Comments

Fairly commented code, but some methods are missing docString comments.

Code Quality

See in-line comments above.

Functionality

Typo in the message: "Successful" -> "Successfully"
Added 2 more functionalities: allocate and remove person; displaying list of unallocated rooms

Testing

Good attempt at writing extensive tests
Good: integrating with TravisCI and Coveralls

…mmand

Fixed Merge conflict

coveralls · 2016-05-12T11:56:38Z

Changes Unknown when pulling 867f918 on master into * on review*.

sunday Nwuguru added 30 commits April 10, 2016 21:10

Added tests/test_room.py andsrc/room.py, I also implemented two test …

c78f364

…cases for room

Added 3 edge cases test for init method of room

e063514

added allocate method placeholder and two instance variables

ea251fa

Merge pull request #1 from andela-snwuguru/room

f244f51

Room

added person class and one test case for person class

588effa

added 5 edges cases for person class

2384095

implemented person init method to pass edge cases test

00bfefa

Merge pull request #2 from andela-snwuguru/person

973c1cb

Person

added 1 test case for allocate method of room

ed16220

implemented allocate method or room to pass new test case

0e19c36

added 5 test cases to room

775a583

implemented room class to pass new added test cases

ad8db54

added 1 test case to room

5a6183f

Implemented room class to pass new test case

5fc9acb

Merge pull request #3 from andela-snwuguru/room

b10d313

Room

Added allocationapp class and one test case for allocationapp

d893558

added data/people.txt and implement loadpeople method to pass 2nd tes…

e375cb0

…t case

added 1 test case for allocationapp

87130d1

added util class and modified allocationapp to pass test cases

b4f6c23

added 3 helper methods to person class and modified allocationapp cla…

1f11a4d

…ss to list people

added helper methods to room class and changed beds variable to peopl…

8d39c91

…e, I also added listallocation method to allocationapp class

added more util methods and implement startapp method in allocationap…

08bc7a7

…p class

added starttipscommandlistener

67a630e

added data/rating.txt, an exit method and also refactored runcommand …

a68db12

…method

refactored runcommand method to accept parameter

de0c501

added clearscreen method to util and implemented it in runcommand met…

6e4b43d

…hod of allocationapp class

implement the LP command functionality

0e88d32

added DB class an test case for db class

eabc198

completed the migration class and added new methods to db class

7036329

added test case for db find method

5aefb04

Nwuguru Sunday added 5 commits May 9, 2016 19:29

Merge pull request #29 from andela-snwuguru/refactor

1e55d63

Freezed all requirements and modified .travis.yml

modified readme

f7227b5

modified readme

8574cfd

modified readme

50f8d22

Merge pull request #30 from andela-snwuguru/refactor

d1f16c7

Modified readme

andela-anandaa reviewed May 11, 2016
View reviewed changes

README.md

One stop solution for room allocation management

### Badges

Copy link

andela-anandaa May 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the badges to below the README title.

Refactored code and added .txt and .pkl to gitignor file

1b1217b

andela-anandaa reviewed May 12, 2016
View reviewed changes

sunday Nwuguru added 11 commits May 12, 2016 11:34

Refactored code and corrected error messages. I also added a clear co…

2882717

…mmand

fixed test cases

0533e4e

modified readme

6851269

removed unnecessary files

4b9fc45

Merge branch 'refactor'

54aa3da

deleted unnecessary files

629940b

deleted files

0f1b2a8

fixed merge conflict

555cd7f

Removed numbering in test cases and corrected misplace docstring

902a586

Corrected merge conflict in requirements.txt

5876629

Merge pull request #33 from andela-snwuguru/refactor

867f918

Fixed Merge conflict

sundayguru closed this May 12, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Checkpoint 1 Review #31

Checkpoint 1 Review #31

sundayguru commented May 11, 2016

coveralls commented May 11, 2016

andela-anandaa May 11, 2016

andela-anandaa May 12, 2016

andela-anandaa commented May 12, 2016 •

edited

Loading

coveralls commented May 12, 2016

Checkpoint 1 Review #31

Checkpoint 1 Review #31

Conversation

sundayguru commented May 11, 2016

coveralls commented May 11, 2016

andela-anandaa May 11, 2016

Choose a reason for hiding this comment

andela-anandaa May 12, 2016

Choose a reason for hiding this comment

andela-anandaa commented May 12, 2016 • edited Loading

README

Github Commits

Comments

Code Quality

Functionality

Testing

coveralls commented May 12, 2016

andela-anandaa commented May 12, 2016 •

edited

Loading