Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkpoint 1 Review Corrections #34

Open
wants to merge 182 commits into
base: review
Choose a base branch
from
Open

Checkpoint 1 Review Corrections #34

wants to merge 182 commits into from

Conversation

sundayguru
Copy link
Owner

What does this PR do?

I corrected all the outline observations during checkpoint review

Description of Task to be completed?

Make the following changes

  • Horizontal alignment of badges
  • remove multiple print lines in the results output
  • Tabulate records display
  • Person Id should be incremental
  • Add doc string to all methods
  • Good error message when reallocation fails
  • Add title to exported files
  • Add optional parameter to save_state command to show logs
  • Add more details to readme project description
  • Move FileMan and Db class to Util
  • Add clear command
  • Reposition Misplaced doc string
  • Removed numbering in amity test cases

sunday Nwuguru added 30 commits April 10, 2016 21:10
Added tests/test_room.py andsrc/room.py, I also implemented two test …
c78f364 
…cases for room
Added 3 edge cases test for init method of room
e063514
added allocate method placeholder and two instance variables
ea251fa
Merge pull request #1 from andela-snwuguru/room
f244f51 
Room
added person class and one test case for person class
588effa
added 5 edges cases for person class
2384095
implemented person init method to pass edge cases test
00bfefa
Merge pull request #2 from andela-snwuguru/person
973c1cb 
Person
added 1 test case for allocate method of room
ed16220
implemented allocate method or room to pass new test case
0e19c36
added 5 test cases to room
775a583
implemented room class to pass new added test cases
ad8db54
added 1 test case to room
5a6183f
Implemented room class to pass new test case
5fc9acb
Merge pull request #3 from andela-snwuguru/room
b10d313 
Room
Added allocationapp class and one test case for allocationapp
d893558
added data/people.txt and implement loadpeople method to pass 2nd tes…
e375cb0 
…t case
added 1 test case for allocationapp
87130d1
added util class and modified allocationapp to pass test cases
b4f6c23
added 3 helper methods to person class and modified allocationapp cla…
1f11a4d 
…ss to list people
added helper methods to room class and changed beds variable to peopl…
8d39c91 
…e, I also added listallocation method to allocationapp class
added more util methods and implement startapp method in allocationap…
08bc7a7 
…p class
added starttipscommandlistener
67a630e
added data/rating.txt, an exit method and also refactored runcommand …
a68db12 
…method
refactored runcommand method to accept parameter
de0c501
added clearscreen method to util and implemented it in runcommand met…
6e4b43d 
…hod of allocationapp class
implement the LP command functionality
0e88d32
added DB class an test case for db class
eabc198
completed the migration class and added new methods to db class
7036329
added test case for db find method
5aefb04
sunday Nwuguru added 29 commits May 3, 2016 09:06
updated .coverages.yml
4d0068f
modified travis.yml
ef409a0
modified travis.yml
a1e4905
modified travis.yml
ad91990
modified travis.yml
a9f91d8
modified travis.yml
9e6982a
modified travis.yml
cca66d3
Added more test cases
4fa5923
Added more test cases for amity class
29cf295
Added more test cases for amity class
1146700
Merge pull request #28 from andela-snwuguru/refactor
a02da78 
Added test cases for Amity class to improve test coverage
Freezed all requirements and modified .travis.yml
9980823
Merge pull request #29 from andela-snwuguru/refactor
1e55d63 
Freezed all requirements and modified .travis.yml
modified readme
f7227b5
modified readme
8574cfd
modified readme
50f8d22
Merge pull request #30 from andela-snwuguru/refactor
d1f16c7 
Modified readme
Refactored code and added .txt and .pkl to gitignor file
1b1217b
Refactored code and corrected error messages. I also added a clear co…
2882717 
…mmand
fixed test cases
0533e4e
modified readme
6851269
removed unnecessary files
4b9fc45
Merge branch 'refactor'
54aa3da
deleted unnecessary files
629940b
deleted files
0f1b2a8
fixed merge conflict
555cd7f
Removed numbering in test cases and corrected misplace docstring
902a586
Corrected merge conflict in requirements.txt
5876629
Merge pull request #33 from andela-snwuguru/refactor
867f918 
Fixed Merge conflict
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 867f918 on master into * on review*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sundayguru @coveralls