Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better align default values with upstream OPNsense HAProxy plugin #22

Merged
merged 1 commit into from Feb 1, 2023

Conversation

fraenki
Copy link
Contributor

@fraenki fraenki commented Feb 1, 2023

Currently several default values for frontends/backends deviate from the HAProxy plugin in OPNsense. As a result, some very rarely used features are enabled by default (SSL client authentication, basic authentication, enforcing HTTP2 for non-SSL connections, and so on). The resulting configs are not very useful unfortunately. :(

This PR corrects these default values and replaces them with the same values that are used by the OPNsense HAProxy plugin.

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (3de31c5) compared to base (3bc181e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          572       572           
=========================================
  Hits           572       572           
Impacted Files Coverage Δ
lib/puppet/type/opnsense_haproxy_backend.rb 100.00% <ø> (ø)
lib/puppet/type/opnsense_haproxy_frontend.rb 100.00% <ø> (ø)
lib/puppet/type/opnsense_haproxy_server.rb 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andreas-stuerz andreas-stuerz added the bugfix Changelog Section: Fixes label Feb 1, 2023
@andreas-stuerz andreas-stuerz merged commit 6aa1dfb into andreas-stuerz:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Changelog Section: Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants