Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer requirements #43

Closed
Jeroen-G opened this issue Jun 15, 2015 · 3 comments
Closed

Composer requirements #43

Jeroen-G opened this issue Jun 15, 2015 · 3 comments

Comments

@Jeroen-G
Copy link
Contributor

I see you have in your require-dev double requirements for illuminate/http. Also, any requirements in require are also loaded in a dev environment, so requiring illuminate/support in require-dev is not necessary I believe.
Is it possible to make the validation optional? I'd like to use the default Laravel, but the prettus/laravel-validation is pulled in anyway. Perhaps it could be optional, so people who want to use it will pull it in themselves? Or am I being a bit selfish with this and are many using this way of validating?
A last question, why are illuminate/http, illuminate/pagination and illuminate/database only in the require-dev?

@andersao
Copy link
Owner

Hello @Jeroen-G You're right, my fault when he was developing the next release will pose as the optional prettus/validator and correct the dependencies . Thanks for the feedback .

@Jeroen-G
Copy link
Contributor Author

You're welcome!

@andersao
Copy link
Owner

@Jeroen-G Released version 2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants