Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output to log when detecting incorrect rate limiters #38

Closed
andersfylling opened this issue Aug 26, 2018 · 1 comment
Closed

output to log when detecting incorrect rate limiters #38

andersfylling opened this issue Aug 26, 2018 · 1 comment
Projects
Milestone

Comments

@andersfylling
Copy link
Owner

andersfylling commented Aug 26, 2018

todo:

  1. check if the expected stored rate limit info is incorrect when receiving a response

issues:

  1. This is concurrent programming, remember to lock the bucket.

when the current values, requests left before rate limited, subtracted by one does not match the rate limits in the header response; output to log, the url + bucket key.

@andersfylling andersfylling added this to the v1.0.0 milestone Aug 26, 2018
@andersfylling andersfylling added this to Low priority in Disgord v1 via automation Aug 26, 2018
@andersfylling andersfylling moved this from Low priority to High priority in Disgord v1 Aug 26, 2018
@andersfylling andersfylling changed the title output to log if the new rate limiter is shorter than the previous one output to log when detecting incorrect rate limiters Sep 8, 2018
@andersfylling
Copy link
Owner Author

Given that people might setup different instances of their bots, this can cause more confusion than it solves as it might spew out data all the time.

Closed unless someone can counter my reasoning.

Disgord v1 automation moved this from High priority to Closed Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Disgord v1
  
Closed
Development

No branches or pull requests

1 participant