New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent Ord and PartialOrd #20

Closed

zigazeljko opened this issue Aug 26, 2021 · 1 comment · Fixed by #21

Contributor

zigazeljko commented Aug 26, 2021

The derived Ord is inconsistent with the PartialOrd, since it does not implement lexicographical ordering.

By the way, it seems the compiler did already detect this issue, but #10 silenced the warning instead of fixing it.

The text was updated successfully, but these errors were encountered:

zigazeljko mentioned this issue

Manually implement Ord and fix clippy warning #21

Merged

anderslanglands closed this as completed in #21

mverleg commented May 31, 2022 •

edited

Loading

I'm running into this bug. Has the fix been published to crates.io? Or otherwise can it be released soon @anderslanglands ? Thanks!

According to docs, v0.8.1 still has Ord derived instead of the impl from #21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment