Adding support for events back

[brightxml]

hi,
I tried several code on adding support for events back to python. without API interface changing.
usage like this
on python side:
add return statements after other js code.

  events={
    "click": "function(params) {alert(params.name); return params.name }"
  }
  s=st_pyecharts(b,events=events)

and s is the value when designated events triggered.

please help taking a look.
thx

Bright Xie

[andfanilo]

Hey @brightxml !

I love it! Thanks for prototyping and testing this, this is fabulous.

I have small nitpicks and then ready to merge and release ;)

EDIT: reference to issue #19

[andfanilo]

Strange, my eslint does not tell me anything here, what warning do you get when you remove this ?

[brightxml]

this is when I run npm start, the terminal ouput this, tell me to add this line. but When I run this at home, it disappear...I guess it's because VS environment I set up.

[andfanilo]

I think your IDE was not configured to use prettier because you have 4 spaces instead of 2..
Could you try running npx prettier --write .\src\EchartsChart.tsx from the streamlit_echarts/frontend folder when you're done with your edits?

[andfanilo]

you can write Object.keys(cleanOnEvents).forEach(function (key) { directly :) I think it's clear enough

[andfanilo]

PS: aaah sorry for the merge conflict. Normally if you just put your code before the useEffect I just pushed it should be all good.

[brightxml]

I'll repush.

[brightxml]

I'll repush.