Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git tag version releases #29

Closed
Jacob-Stevens-Haas opened this issue Apr 14, 2023 · 3 comments · Fixed by #33
Closed

Git tag version releases #29

Jacob-Stevens-Haas opened this issue Apr 14, 2023 · 3 comments · Fixed by #33

Comments

@Jacob-Stevens-Haas
Copy link
Collaborator

Hey Andy, I'm trying to bump the requirement specifier for pysindy and looking for the first release that has a particular code change. The git repo only has tags for 0.3.1 and 0.4.2. Not sure what your release workflow is, but could you add a git tag when you release?
@Jacob-Stevens-Haas Jacob-Stevens-Haas mentioned this issue Apr 14, 2023
Open
@andgoldschmidt
Copy link
Owner

Working on adding CI/CD with GitHub actions and poetry to resolve this. The test action under development has a poetry install that takes ~10 min., and it's unclear to me why. This might be another point in favor of Issue #27.

@andgoldschmidt
Copy link
Owner

CI added in #31, CD for releases is still TODO. Regarding the previous comment, I found that poetry install was too slow unless the poetry.lock file was committed.

@Jacob-Stevens-Haas
Copy link
Collaborator Author

Awesome, thanks Andy! Congrats on the CI!

@andgoldschmidt andgoldschmidt mentioned this issue May 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GitHub Action - Release andgoldschmidt/derivative
2 participants
@andgoldschmidt @Jacob-Stevens-Haas