Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore): remove dynamic import from useCountFromServer #162

Merged
merged 4 commits into from
Nov 25, 2022

Conversation

andipaetzold
Copy link
Owner

No description provided.

@andipaetzold andipaetzold self-assigned this Oct 18, 2022
@andipaetzold andipaetzold added this to the v3 milestone Oct 18, 2022
@andipaetzold andipaetzold force-pushed the useCountFromServer-no-dynamic-import branch 2 times, most recently from 47160bc to 04479ac Compare October 18, 2022 19:30
@andipaetzold andipaetzold changed the base branch from main to bump-min-firebase-version October 18, 2022 19:30
@andipaetzold andipaetzold force-pushed the useCountFromServer-no-dynamic-import branch from 04479ac to 501d171 Compare October 18, 2022 19:38
@andipaetzold andipaetzold marked this pull request as ready for review November 25, 2022 21:43
Base automatically changed from bump-min-firebase-version to next November 25, 2022 21:51
@github-actions
Copy link

github-actions bot commented Nov 25, 2022

Size Change: -42 B (0%)

Total Size: 15.4 kB

Filename Size Change
lib/firestore/useCountFromServer.js 499 B -42 B (-8%)
ℹ️ View Unchanged
Filename Size
lib/app-check/index.js 59 B
lib/app-check/useAppCheckToken.js 421 B
lib/auth/index.js 75 B
lib/auth/useAuthIdToken.js 562 B
lib/auth/useAuthIdTokenResult.js 578 B
lib/auth/useAuthState.js 434 B
lib/common/index.js 48 B
lib/common/types.js 31 B
lib/database/index.js 70 B
lib/database/internal.js 158 B
lib/database/useObject.js 396 B
lib/database/useObjectOnce.js 455 B
lib/database/useObjectValue.js 693 B
lib/database/useObjectValueOnce.js 631 B
lib/firestore/index.js 116 B
lib/firestore/internal.js 344 B
lib/firestore/types.js 31 B
lib/firestore/useCollection.js 576 B
lib/firestore/useCollectionData.js 690 B
lib/firestore/useCollectionDataOnce.js 602 B
lib/firestore/useCollectionOnce.js 554 B
lib/firestore/useDocument.js 601 B
lib/firestore/useDocumentData.js 689 B
lib/firestore/useDocumentDataOnce.js 587 B
lib/firestore/useDocumentOnce.js 562 B
lib/index.js 107 B
lib/internal/useIsMounted.js 185 B
lib/internal/useListen.js 491 B
lib/internal/useLoadingValue.js 351 B
lib/internal/useOnce.js 471 B
lib/internal/useStableValue.js 200 B
lib/messaging/index.js 60 B
lib/messaging/useMessagingToken.js 417 B
lib/storage/index.js 90 B
lib/storage/internal.js 142 B
lib/storage/useBlob.js 541 B
lib/storage/useBytes.js 507 B
lib/storage/useDownloadURL.js 395 B
lib/storage/useMetadata.js 388 B
lib/storage/useStream.js 547 B

compressed-size-action

@andipaetzold andipaetzold force-pushed the useCountFromServer-no-dynamic-import branch from a0f3bbf to d6c61ba Compare November 25, 2022 21:59
@andipaetzold andipaetzold merged commit 47a03f6 into next Nov 25, 2022
@andipaetzold andipaetzold deleted the useCountFromServer-no-dynamic-import branch November 25, 2022 22:01
github-actions bot pushed a commit that referenced this pull request Nov 25, 2022
# [3.0.0-next.3](v3.0.0-next.2...v3.0.0-next.3) (2022-11-25)

### Bug Fixes

* **firestore:** remove dynamic import from useCountFromServer ([#162](#162)) ([47a03f6](47a03f6))
@github-actions
Copy link

🎉 This PR is included in version 3.0.0-next.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Aug 1, 2023
# [3.0.0](v2.5.0...v3.0.0) (2023-08-01)

### Bug Fixes

* **firestore:** remove dynamic import from useCountFromServer ([#162](#162)) ([47a03f6](47a03f6))
* properly cleanup `useQueries*` on unmount ([b77becc](b77becc))

### Features

* rename `useCollection*` hooks to `useQuery*` ([#194](#194)) ([372f055](372f055))
* require firebase 9.11.0 or later ([#148](#148)) ([7da01b0](7da01b0))
* target es2017 instead of es2015 ([#163](#163)) ([be187d0](be187d0))
* useQueries & useQueriesData ([#193](#193)) ([03be7c8](03be7c8))

### BREAKING CHANGES

* `useCollection*` hooks are renamed to `useQuery*`
* require firebase 9.11.0 or later
* package targets es2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant