Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'nbf' not handled correctly #3

Closed
DaWalker opened this issue Jun 20, 2017 · 1 comment
Closed

'nbf' not handled correctly #3

DaWalker opened this issue Jun 20, 2017 · 1 comment

Comments

@DaWalker
Copy link

I think JwtTokenBuilder.java:145 should be computing the difference between the 'iat' (issuedAt) time and the 'nbf' (notBeforeTime), but it is computing the sum instead.

e.g. (using small values for the sake of clarity) if 'iat' is 1000 and 'nbf' is 900, the leeway should be 100 (issuedAt - notBefore), not 1900 (notBefore + issuedAt).

@andreacomo
Copy link
Owner

You' right. I made a test to prove and fix it, thank you.
Fix will be available from version 2.0.1 for Tomcat 8 and 1.1.1 for Tomcat 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants