Complete Name should be descriptive even when new iPhones get released #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the complete name. If this is used for sending it to the server it will still be useful without the need to update the entire app
|
I've also updated the Cocoapod. Thanks for your addition! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took a while, but we recently noticed that the new iPhone X (and 8, 8+) would be named as "Unknown-Unknown-Unknown" when we use an old version of the library.
In some cases this may be okay, when you check the
typeormodelbefore submitting that name to the server. I think it would be a nice addition if the identifier is added to the complete name if the device is unknown in the current state of the library.This would prevent in some cases that the app needs to be updated just because new phones came out which are not on the list.
I hope you agree to my addition