New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Luminous.Carrier.networkCountryCode should be .mobileNetworkCode #5

Closed

ethanhuang13 opened this issue May 22, 2017 · 2 comments

Assignees

ethanhuang13 commented May 22, 2017

I haven't use this library, just saw your source code.

I think Luminous.Carrier.networkCountryCode should be .mobileNetworkCode(MNC) in
https://github.com/andrealufino/Luminous/blob/master/Luminous/Classes/Luminous.swift

Author

ethanhuang13 commented May 22, 2017

It's also carrierMobileNetworkCode in ALSystemUtilities.

https://github.com/andrealufino/ALSystemUtilities/blob/develop/ALSystemUtilities/ALSystemUtilities/ALCarrier/ALCarrier.m

andrealufino self-assigned this

Owner

andrealufino commented May 23, 2017

Yes, you're right.
Done in version 0.50.30, already published on cocoapods.
This is the interested commit.

andrealufino closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment