Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift version #115

Closed
andreamazz opened this issue May 8, 2017 · 10 comments
Closed

Swift version #115

andreamazz opened this issue May 8, 2017 · 10 comments

Comments

@andreamazz
Copy link
Owner

Hi everyone,
I've converted the library in Swift, and took the chance to clean up part of the API.
Since part of the code was refactored, some manual tests for some edge cases would be welcomed 馃槵

For now everything is in the swift branch, the current version will live under the v1.x branch.

@nevinjethmalani
Copy link

I am getting an issue with the arrow not being centered in the frame. It is slightly pushed to the left side of the frame that I am tapping. Here is the code I am using:

self.popTip.show(text: theText, direction: .up, maxWidth: 250, in: self.mainView, from: (sender as AnyObject).frame)

@andreamazz
Copy link
Owner Author

Hi @nevinjethmalani
Yeah, I've noticed that this issue arise when you have a poptip with the bouncing animation and you dismiss it while it's bouncing down. When you reopen it, it's shifted. This can be observed in the demo project.
I'll fix it as soon as possible.

@andreamazz
Copy link
Owner Author

Ok, the latest commit seems to have fixed this issue, let me know if you are still experiencing it

@andreamazz andreamazz reopened this May 17, 2017
@nevinjethmalani
Copy link

I am still having the problem. Even if I don't dismiss it when it is bouncing, I have this issue.

@andreamazz
Copy link
Owner Author

Can you post more details to help me reproduce the issue? e.g.: some info on the view containing it and the frame originating it.

Thanks

@Kaspik
Copy link

Kaspik commented Jun 27, 2017

Would it be possible to make even this new swift version compatible with Obj-C apps? Like adding @objc in front of the class to make it obj-c public-visible?

@andreamazz
Copy link
Owner Author

Hey @Kaspik
The swift version uses some swift-only constructs (mainly associated enum values) that are not available to Objective-C, so by design I decided to limit the compatibility from the start. The Objective-C version (branch v1.x) is stable though, and offers the same features, so you can point to that one instead.

@Kaspik
Copy link

Kaspik commented Jun 28, 2017

@andreamazz Thanks for the response. Yeah we already use the older version, the question was more like if you already have half of the code with prefix @objc then if you are going to do it fully objc compatible or not.
That (one?) associated enum could be maybe represented by struct but i understand you.
It's not like we don't wanna use swift but our project is so huge that right now it's not possible to rewrite it as you did... and we don't wanna loose new functions of this library. 馃様

Thanks anyways!

@vickydhas
Copy link

Can you give the pod link for the ObjC version please.

@vickydhas
Copy link

I managed : pod 'AMPopTip' , '~>1.x'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants