Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Did you drop iOS 9-10 support? #130

Closed
sample-repo opened this issue Sep 18, 2017 · 8 comments
Closed

Did you drop iOS 9-10 support? #130

sample-repo opened this issue Sep 18, 2017 · 8 comments

Comments

@sample-repo
Copy link

I cannot build the last release using Xcode 8.3.3 (8E3004b).
The error is "Use of unresolved identifier 'NSAttributedStringKey'".
According to documentation NSAttributedStringKey works under iOS 11.0+.

@andreamazz
Copy link
Owner

@sample-repo
Copy link
Author

sample-repo commented Sep 18, 2017

To be honest it is not good decision to support only the latest version. And it is not user-friendly behaviour for devs who use your awesome library.
Probably, you will introduce new features or fix some bugs in the future. As a result, the changes won't affect lower versions.

The golden rule defined on our project is "keep libraries up-to-date". For now I am thinking of alternative.

@andreamazz
Copy link
Owner

Swift 3 version is not deprecated, it just lives in the swift3 branch.

@dirtmelon
Copy link

I do not think it's a good decision.If I want support iOS 9-10,I must use Swift 3,I can't use Swift 4,so sad.

@andreamazz
Copy link
Owner

@dirtmelon The library works with iOS9 and 10, you just need to compile with Xcode 9, you get compile errors if you try the swift 4 version with Xcode 8 (obviously).

@dirtmelon
Copy link

I found the Swift 4 version is using NSAttributedStringKey,such as @sample-repo say,NSAttributedStringKey works under iOS 11.0+.

@andreamazz
Copy link
Owner

andreamazz commented Sep 20, 2017

@dirtmelon
if you bothered to run it on iOS 10 you would have noticed that it runs with no issues. More so, this is the header for that symbol:
http://d.pr/i/XaXWJ
it has no @available. So I really don't see the issue here. :|

@dirtmelon
Copy link

sorry,that's my fault,I update podfile as #124 ,it compiles okay.Thank you very much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants