Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition between View Controllers issue #3

Closed
robmontesinos opened this issue Apr 30, 2014 · 3 comments
Closed

Transition between View Controllers issue #3

robmontesinos opened this issue Apr 30, 2014 · 3 comments

Comments

@robmontesinos
Copy link

In my app, I have a couple of View Controllers each with a tableview as well as a HeaderView. the transition in the cells work well but the header views don't animate well. For example, both header views are visible during the transition before the initial header view animates out. This is not good.

The reason I use a View Controller with subviews (tableview and header view) instead of a tableview controller is for ad banner support. The ads are difficult to control with the tableview controller.

Any ideas on how I should handle the header view animations - I'd really like to use this library in my upcoming app. Thank you.

@andreamazz
Copy link
Owner

Hi @robmontesinos
The first quick fix that comes to my mind is this:
Wrap your header in a UIView if you didn't already. In your visibleCells implementation you can add the header's UIView to the returned NSArray, alongside the table's cells (it should be the first element of the array if the view is on top). The transition object treats that array like a collection of UIViews, so the header should animate just fine.
I didn't test this method, but it should work. I'll add it to the sample project later.

@andreamazz
Copy link
Owner

Check the sample in commit ada210f

@robmontesinos
Copy link
Author

Thank you so much Andrea. It is working amazingly well. Salud!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants