New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
destinationViewController's autolayout doesn't work. #17
Comments
Hi @bianjingbulb |
@andreamazz thanks for replying me!!! |
Ok, but if you remove the bubble transition (and perform the system transition instead), does the issue go away? |
Can you provide a sample showing this issue? Or at least reproduce the issue in the demo project? I'm having trouble reproducing this. |
I've got the same problem. When using everything in full code the destination controller layout constraints are broken... |
Please provide a sample showing the issue, I can't debug something that I can't reproduce. |
I just tried it in a new project and now it works. In my real app it doesn't. Then the constraints are broken. In the top left corner you see a label with some text and the constraints are center in middle of viewcontroller.. |
I found the problem in my real app my ViewControllers have a BaseViewController that does some things. If I use this controller as base then it doesn't work:
|
I observed the same issue. My destination view controller has map view and it doesn't zoom to correct map area to show all annotations because its frame wasn't set correctly by this animator. The problem is about using if transitionMode == .present {
...
let finalFrame = transitionContext.finalFrame(for: toViewController!)
let originalCenter = CGPoint(x: finalFrame.width / 2, y: finalFrame.height / 2)
let originalSize = finalFrame.size
...
// Inside the animation block, set the frame:
UIView.animate(withDuration: .. {
...
presentedControllerView.frame = finalFrame
} |
I'm facing this same issue... Anyone care to share how to fix it? @ozgur @donpironet @andreamazz |
@andreamazz maybe you have an update on this? To me, a new PR is likely needed. |
Again, I need a sample that reproduces the issue to test it. |
I had the same problem as you. This was solved putting the ViewController inside a storyboard. in a xib does not work |
Closing this for now. Feel free to reopen if you have sample code to reproduce the issue, or even better a PR. |
I've had the same problem, because I use xib. My workaround: Steps to reproduce (I'm not sure):
Transition uses size from xib |
Hi, friend! Thanks for you great work.
Here is a problem.
The destinationViewController's autolayout doesn't work after I user BubbleTransition to present it.
↑ my storyboard
↑ devise screen.
Can you give me some ideas?
Thanks!
The text was updated successfully, but these errors were encountered: