Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in method name. increseVolume -> increaseVolume #26

Closed
jwandrews opened this issue May 31, 2019 · 3 comments
Closed

Typo in method name. increseVolume -> increaseVolume #26

jwandrews opened this issue May 31, 2019 · 3 comments

Comments

@jwandrews
Copy link

Found a typo in method name:

@objc public func increseVolume(by step: Double = DefaultVolumeStep, animated: Bool = false) throws {

I guess this would be a breaking change since it’s changing public API.

@andreamazz
Copy link
Owner

Yep, I noticed a while ago, cried about it a little bit, and hoped that no one would notice.

😬

I'll fix it and release a new minor.

@andreamazz
Copy link
Owner

Done, released 1.1.0

@jwandrews
Copy link
Author

wonderful! keep up the good work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants