Fix the reset to CGAffineTransformIdentity not being animated #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once again, thanks! |
andreamazz
added a commit
that referenced
this pull request
May 28, 2014
Fix the reset to CGAffineTransformIdentity not being animated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reseting the text field to its original position with
CGAffineTransformIdentity, the change is not animated, which makes the text field "jump" at the end of the animation.Before fix: https://dl.dropboxusercontent.com/u/18386288/UIView%2BShake_before.mov
After fix: https://dl.dropboxusercontent.com/u/18386288/UIView%2BShake_after.mov
(sorry, .mov videos, could not find a satisfying gif converter...)
Also, please note that the first and last animations are executed with the same duration as all the others shakes, but the distance travelled by the view is 2x smaller, making these appear "slower".
Issue mirrored for UIView+Shake here: andreamazz/UIView-Shake#1