Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UINavigationControllerOperationPop delta for fromVC #17

Closed
cohen72 opened this issue Nov 17, 2014 · 2 comments
Closed

UINavigationControllerOperationPop delta for fromVC #17

cohen72 opened this issue Nov 17, 2014 · 2 comments

Comments

@cohen72
Copy link

cohen72 commented Nov 17, 2014

I noticed on my pop animations, the cells of the fromVC were animating properly, however the superview was animating backwards (to the left), when it was supposed to be animating to the right.

I finally narrowed down that on line 414, I was able to fix the issue by changing:

[fromVC.view setTransform:CGAffineTransformMakeTranslation(delta, 0)];

to:

[fromVC.view setTransform:CGAffineTransformMakeTranslation(0, 0)];

I'm not sure if that is a bug, or if it was intended to be that way, but with the change I made, the animation looks a lot cleaner.

Can you let me know if I made a proper change, or if I potentially screwed something else up in doing this change?

Thanks for the great work!

@andreamazz
Copy link
Owner

Hi @cohen72
Yep, you are right, looks like it's a bug. nice catch. I'll push ew version later.

@cohen72
Copy link
Author

cohen72 commented Nov 17, 2014

Thanks for the quick response! All the Best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants