Translate expect vs should syntax to zh-tw #160
Conversation
gaga5lala
changed the title
| @@ -258,7 +259,7 @@ | |||
| </p> --> | |||
|
|
|||
| <p> | |||
| 「單一條件」意指一個測項應該只帶有一個檢查 (expection, assertion)。這樣做能幫助你直接前往失敗的測項尋找可能的問題，也讓程式碼比較好看。 | |||
| 「單一條件」意指一個測項應該只帶有一個檢查 (expectation, assertion)。這樣做能幫助你直接前往失敗的測項尋找可能的問題，也讓程式碼比較好看。 | |||
There was a problem hiding this comment.
why this change?
The 'one expectation' tip is more broadly expressed as 'each test should make only one assertion'. This helps you on finding possible errors, going directly to the failing test, and to make your code readable.
http://betterspecs.org/#single
There was a problem hiding this comment.
Thanks, for your review :)
I can't find "expection" in oxford dictionary, so I think it's should be noun for expect, so I change this to "expectation"
http://www.oxfordlearnersdictionaries.com/spellcheck/english/?q=expection
Maybe I misunderstood it's means?
There was a problem hiding this comment.
I think this could be translated into:
「單一條件（one expectation）」泛指一個測項應該只有一個檢查（assertion）。
gaga5lala
force-pushed
the
translate-expect-vs-should-syntax-to-zh-tw
branch
from
b4cab07
to
9cfda49
Compare
|
Hi @JuanitoFatas , thanks for all your suggestions :) Follow your suggestions, I push 2 new commit to fix them, one only thing I haven't change is keeping comment out original text. |
|
LGTM. |
|
@JuanitoFatas thank you for reviewing this translation PR. And @gaga5lala thank you for your fixes! |
…tax-to-zh-tw Translate expect vs should syntax to zh-tw
Thanks for this awesome guide :)
In this PR, fix a typo and translate "expect vs should syntax" to zh-tw