Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tool and the action have different defaults, which is confusing #3

Open
ulysses4ever opened this issue May 13, 2024 · 0 comments
Open

Comments

@ulysses4ever
Copy link

With input configfile one can specify the configuration file (defaults to fix-whitespace.yaml).

I find the default confusing in a scenario when I try to repro it locally and I can't run the action. I run fix-whitespace manually, and, of course, I get different results if I forget that I need to specify the config manually.

In short, I think the action and the tool should have the same default, if possible. Perhaps, people will be unhappy if you remove the default value from the action. So, a less disruptive way would be to add the same default to the tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant