Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: ctrl + C -> unexpected behaviour #23

Closed
1 task done
AndreasAugustin opened this issue Aug 17, 2023 · 0 comments · Fixed by #27
Closed
1 task done

[Bug]: ctrl + C -> unexpected behaviour #23

AndreasAugustin opened this issue Aug 17, 2023 · 0 comments · Fixed by #27
Assignees
@AndreasAugustin
Labels
bug Something isn't working

Comments

@AndreasAugustin
Copy link
Owner

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

In some scenarios one like to close the current session. Normally ctrl + C is doing such a thing in most tty.

But the current implementation will lead in most cases to next prompt

Expected Behavior

ctrl + C should terminate the go-gitmoji-cli session

Current Behavior

in most cases the next prompt will be opened.

Steps To Reproduce

  1. use config or commit cmd
  2. press ctrl + C
  3. next prompt will open

Possible Solution

check the keymap within the UI elements

Additional Information/Context

No response

go-gitmoji-cli Version

v0.1.0-pre-alpha
@AndreasAugustin AndreasAugustin added the bug Something isn't working label Aug 17, 2023
@AndreasAugustin AndreasAugustin self-assigned this Aug 17, 2023
AndreasAugustin added a commit that referenced this issue Aug 18, 2023
@AndreasAugustin
fix: 🐛 (#23) fix issue with ctrl+c
f0b9566
@AndreasAugustin AndreasAugustin mentioned this issue Aug 18, 2023
Merged
AndreasAugustin added a commit that referenced this issue Aug 18, 2023
@AndreasAugustin
fix: 🐛 (#23) fix issue with ctrl+c
3bda78d
AndreasAugustin added a commit that referenced this issue Aug 18, 2023
@AndreasAugustin
fix: 🐛 (#23) fix issue with ctrl+c
85f12eb
AndreasAugustin added a commit that referenced this issue Aug 18, 2023
@AndreasAugustin
fix: 🐛 (#23) fix issue with ctrl+c
8a79ac7
AndreasAugustin added a commit that referenced this issue Aug 18, 2023
@AndreasAugustin
fix: 🐛 (#23) fix issue with ctrl+c (#27)
92e3f68 
* fix: 🐛 (#23) fix issue with ctrl+c

* fix: 🐛 (#23) fix issue with ctrl+c

* fix: 🐛 (#23) fix issue with ctrl+c

* fix: 🐛 (#23) fix issue with ctrl+c

* chore(ci): 👷 remove golang version, add macos runner
AndreasAugustin added a commit that referenced this issue Aug 18, 2023
@AndreasAugustin
fix: 🐛 (#23) fix issue with ctrl+c
3432b04
@github-actions github-actions bot mentioned this issue Aug 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreasAugustin AndreasAugustin

Labels
bug Something isn't working
Projects
go-gitmoji-cli
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 🐛 (#23) fix issue with ctrl+c AndreasAugustin/go-gitmoji-cli
1 participant
@AndreasAugustin