Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating x_ite_dom into X_ITE #40

Open
create3000 opened this issue Nov 19, 2022 · 7 comments
Open

Integrating x_ite_dom into X_ITE #40

create3000 opened this issue Nov 19, 2022 · 7 comments

Comments

@create3000
Copy link
Contributor

Hello Andreas,

I have integrated x_ite_dom directly into X_ITE now, because it is much easier to maintain this file this way, and there is now no more need to include and extra file. I have already fixed some new issues, like #38, and also fixed dispose of nodes in X_ITE, which was broken. Also some things in the parser have changed since start of this project, and the new preferred element is <x3d-canvas>. It also solves the problem if a x3d-canvas element is created programmatically via X3D.createBrowser and added later to the HTML document.

I would very appreciate it if you would continue to maintain the file, and also continue to add ideas to it.

DOMIntegration.js is now located here https://github.com/create3000/x_ite/blob/main/src/x_ite/Browser/DOMIntegration.js.

@jamesleesaunders
Copy link

Thanks for fixing #38 and I am excited to hear x_ite_x3dom is now being integrated into x_ite as standard.
I will give this a test with d3-x3d.

@create3000
Copy link
Contributor Author

create3000 commented Nov 19, 2022

@jamesleesaunders Nice to hear from you, but notice, I will release the new version with these critical fixes first in 3 or 4 days. Wanted to inform Andreas first. Have you noticed that the element is now <x3d-canvas> (with dash, and lowercase), and there is no need to include the CSS anymore :).

Minimal example can be found already at https://create3000.github.io/x_ite/DOM-Integration.html#example.

@create3000
Copy link
Contributor Author

@jamesleesaunders if you are impatient then you can test the alpha version from https://create3000.github.io/code/x_ite/alpha/x_ite.min.js (or without '.min').

@jamesleesaunders
Copy link

@create3000 Thanks! I have given all the charts on d3-x3d a run though with the alpha version and they all appear to be running fine :-) I have also swapped all examples and docs to x3d-canvas.

It may be a little premature, but I have published all examples to use the alpha version:
https://github.com/jamesleesaunders/d3-x3d#examples
I will update them again when it is released as dist.

I will also take a look over #38 to see if this is now fixed.

@create3000
Copy link
Contributor Author

@jamesleesaunders a new version is now published, and you can now use 'latest' to refer to x_ite. I also have tested #38 and it should now be fixed.

@jamesleesaunders
Copy link

Great! I have flipped over to latest.
I have also addresses complains from non-standard 'ENVIRONMENT' element (non standard from x3dom).

I am seeing a couple of new warnings from x-ite which I don't think were there on previous versions:

Texturing3D.js:13 Invalid asm.js: Invalid member of stdlib
Texturing3D.js:49 Invalid asm.js: Invalid member of stdlib

See console:
https://raw.githack.com/jamesleesaunders/d3-x3d/master/examples/X_ITE/chart/AreaChartMultiSeries.html

Welcome to X_ITE X3D Browser 8.0.0:
   Current Graphics Renderer
      Name: Google Inc. (Apple) ANGLE (Apple, Apple M1 Pro, OpenGL 4.1)
      WebGL version: WebGL 2.0 (OpenGL ES 3.0 Chromium)
      Shading language: WebGL GLSL ES 3.00 (OpenGL ES GLSL ES 3.0 Chromium)

@andreasplesch
Copy link
Owner

Apologies for delayed response. I fully support integrating x_ite_dom into X_ITE. Let me add a note to the repo.

I will be happy to support the integration albeit sometimes slowly. With the easier access, support for html rather than xhtml may become more relevant. As far as I remember, html should already work well with the support in x_ite. The main tag to test would be probably <script>.

Thanks for doing this, Andreas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants