protect against illegal props

lib/neo4j/shared/property.rb

@@ -11,6 +11,9 @@ module Property
 
     class UndefinedPropertyError < RuntimeError; end
     class MultiparameterAssignmentError < StandardError; end
+    class IllegalPropertyError < StandardError; end
+
+    ILLEGAL_PROPS = %w[from_node to_node start_node end_node]
 
     def initialize(attributes={}, options={})
       attributes = process_attributes(attributes)
@@ -141,17 +144,10 @@ module ClassMethods
       #      property :name, constraint: :unique
       #    end
       def property(name, options={})
+        check_illegal_prop(name)
         magic_properties(name, options)
         attribute(name, options)
-
-        # either constraint or index, do not set both
-        if options[:constraint]
-          raise "unknown constraint type #{options[:constraint]}, only :unique supported" if options[:constraint] != :unique
-          constraint(name, type: :unique)
-        elsif options[:index]
-          raise "unknown index type #{options[:index]}, only :exact supported" if options[:index] != :exact
-          index(name, options) if options[:index] == :exact
-        end
+        constraint_or_index(name, options)
       end
 
       def default_property(name, &block)
@@ -184,6 +180,23 @@ def cached_class?
 
       private
 
+      def constraint_or_index(name, options)
+        # either constraint or index, do not set both
+        if options[:constraint]
+          raise "unknown constraint type #{options[:constraint]}, only :unique supported" if options[:constraint] != :unique
+          constraint(name, type: :unique)
+        elsif options[:index]
+          raise "unknown index type #{options[:index]}, only :exact supported" if options[:index] != :exact
+          index(name, options) if options[:index] == :exact
+        end
+      end
+
+      def check_illegal_prop(name)
+        if ILLEGAL_PROPS.include?(name.to_s)
+          raise IllegalPropertyError, "#{name} is an illegal property"
+        end
+      end
+
       # Tweaks properties
       def magic_properties(name, options)
         set_stamp_type(name, options)

spec/unit/shared/property_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+
+describe Neo4j::Shared::Property do 
+  let(:clazz) { Class.new { include Neo4j::Shared::Property } }
+
+  describe ':property class method' do
+    it 'raises an error when passing illegal properties' do
+      Neo4j::Shared::Property::ILLEGAL_PROPS.push 'foo'
+      expect{clazz.property :foo}.to raise_error(Neo4j::Shared::Property::IllegalPropertyError)
+    end
+  end
+end