Moodle 2.3 and Order...

[tallthom]

Hi Andre,

Hope things are well. There hasn't been any movement on the "order" question type with respect to Moodle 2.3. However, I spotted a problem that cropped up - I'm not sure when that would have been because I can't identify the code where this is checked. Maybe you could help me narrow the focus.

The symptoms are that if you have a field in the list of items to be ordered that is identical to another field, it gives an error if you don't put those fields in the correct order. For example - students have to order each [word] in this sentence:

[Bob likes] [cats] [and] [Mary likes] [cats] [,] [too] [.]

In 1.9, no matter which [cats] I put in the sentence, the system would mark it correct. In 2.3, that no longer happens. I think it is related to the editor being used for the ordering. In 1.9 there was only auto format, but the 2.3 ordering question type has a TinyMCE editor for each field. It puts some HTML tags in with each entry which may cause problems when it is parsed for correctness (I'm guessing).

I'll try to look more deeply into it, but I wanted to open an issue on it.

[andreev-artem]

I plan upgrading to Moodle 2.3 within a month. Then I will try to reproduce and fix problem.

[ruddj]

Not sure if it is of use but Jean-Michel Védrine has posted a 2.3 compatibility fix here: http://moodle.org/mod/forum/discuss.php?d=206145

[andreev-artem]

@ruddj It is hard to understand what is changed in Jean-Michel Védrine version. I take a closer look to his version at the end of week.

[ruddj]

A few things:

• More details in version.php file
• questiontype.php
  • Added Import and Export functionality
  • Appears to fix a incorrect label on line 207,209,211 where it refers to qtype_multichoice instead of qtype_order
• lib.php
  • Adds the extra array argument options introduced in 2.3
• edit_order_form.php
  • Changed passing from by reference
• Adds French Translation

I can probably generate a diff of the changes if that would help?

[andreev-artem]

@ruddj Thanks. I've merged Jean-Michel Védrine changes.

[ruddj]

Thanks @andreev-artem. Only thing I'm not sure about are changes to DB structure in install.xml. Previously you had UNSIGNED="true" or UNSIGNED="false" for different fields, but Jean-Michel did not have this.
I was unsure if you added this after he created his patch, or if he changed this for a particular reason.

[andreev-artem]

@ruddj Seems as part of DB layer improvements for 2.3. See http://tracker.moodle.org/browse/MDL-27982

[ruddj]

Thanks @andreev-artem that seems to be the reason for the change.