Fix lock re-entrancy in process_append_entry_request_as_follower() #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my project, I have a struct that implements both the
Cluster
andStateMachine
traits, and, therefore, also share the sameMutex
that's passed to
Replica
.However,
process_append_entry_request_as_follower
is holding on to thestate machine lock while attempting to acquire the cluster lock, which
results in re-entrancy that causes a deadlock (as reported by
no_deadlocks
crate):Fix the deadlock by moving entry processing to a separate function,
which reduces the scope of the state machine lock so that it is no
longer held when we attempt to acquire the cluster lock.
Fixes #42.