Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an IntelliJ code style / code formatting config #279

Open
andregasser opened this issue Oct 11, 2023 · 4 comments
Open

Create an IntelliJ code style / code formatting config #279

andregasser opened this issue Oct 11, 2023 · 4 comments
Labels
code quality Everything related to code quality needs discussion It is not yet entirely clear on how to address this issue

Comments

@andregasser
Copy link
Owner

The default IntelliJ formatting rules for Kotlin code deviate in some places from what we have in this project:

We should create an IntelliJ code formatting config for Kotlin that is automatically loaded by IntelliJ once the project loads.

@andregasser andregasser added the code quality Everything related to code quality label Oct 11, 2023
@PattaFeuFeu
Copy link
Collaborator

Project does not allow star imports, IntelliJ formatter reformats code to use star imports

Just checked: gradle check does not raise any issues with star imports

@andregasser
Copy link
Owner Author

Hello @PattaFeuFeu Thanks for the feedback. Will try to fix this asap. Cheers

@andregasser
Copy link
Owner Author

@PattaFeuFeu Do we have an important need for this - especially since we've introduced ktlint? If not, I suggest we close this and focus on more important topics for now. Any objections?

@andregasser andregasser added the needs discussion It is not yet entirely clear on how to address this issue label Oct 27, 2023
@PattaFeuFeu
Copy link
Collaborator

Let me check again when working on a larger task. Then I should notice any oddities in the auto-formatter.

But either way I wouldn’t mind this ticket staying open. It’s not like an open ticket is keeping us from working on other tasks. 😊 If someone is in a mood to pick this up, they can still do that at any point in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Everything related to code quality needs discussion It is not yet entirely clear on how to address this issue
Projects
None yet
Development

No branches or pull requests

2 participants