Add ability to chunk CSV in either row or file #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WToa
commented
Apr 2, 2024
|
|
||
| def chunk_mode | ||
| if @options[:chunk_mode].to_s.empty? | ||
| CHUNK_MODE[:row] |
There was a problem hiding this comment.
Not sure about this, I'm defaulting to row
| .compact | ||
| .map(&:strip) | ||
| .join(separator) | ||
| end.join("\n\n") |
There was a problem hiding this comment.
From what I can tell, by default if a string is separated by \n\n then it gets chunked when it's acted on by Langchain::Chunker::Text Let me know if that's incorrect or you prefer a different approach
WToa
force-pushed
the
add-chunk-csv-by-row-or-file
branch
from
4efbbf5
to
ee25bf1
Compare
|
@WToa Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking to address the issue in #549