New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enki tests explicitly try to load non-namespaced sip module #464
Comments
and upstream reference to the change, |
I do not support the tests now, because there are a lot of hard-to-track infrastructure problems and the tests consume much more time than save. |
As tests/base.py is considered, I can't build a new package in Fedora without disabling execution of nearly all tests. |
@rapgro, just disable the tests. They are not supposed to be run automatically now. |
Please, don't drop the tests. If they've any sense you should keep with them. That's how TDD should work. Maybe we can drop some difficult platforms then and instead? |
Recent upstream sip releases generally only support namespaced sip modules, which is what fedora (sip/PyQt5) packaging is now trying to implement, and drop support for non-namespaced sip module.
In investigations removing this support, one problematic case was enki that includes code in tests currently like:
tests/test_lib/test_future.py:import sip
tests/test_lib/test_future.py: sip.delete(o)
tests/base.py:import sip
tests/base.py: sip.delete(timer)
tests/base.py: sip.delete(qe)
Possible fixes include:
or
See also downstream issue,
https://bugzilla.redhat.com/show_bug.cgi?id=1752766
The text was updated successfully, but these errors were encountered: