Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enki tests explicitly try to load non-namespaced sip module #464

Closed
rdieter opened this issue Oct 2, 2019 · 5 comments
Closed

enki tests explicitly try to load non-namespaced sip module #464

rdieter opened this issue Oct 2, 2019 · 5 comments

Comments

@rdieter
Copy link

rdieter commented Oct 2, 2019

Recent upstream sip releases generally only support namespaced sip modules, which is what fedora (sip/PyQt5) packaging is now trying to implement, and drop support for non-namespaced sip module.

In investigations removing this support, one problematic case was enki that includes code in tests currently like:

tests/test_lib/test_future.py:import sip
tests/test_lib/test_future.py: sip.delete(o)
tests/base.py:import sip
tests/base.py: sip.delete(timer)
tests/base.py: sip.delete(qe)

Possible fixes include:

  • replacing 'sip' with 'PyQt5.sip'
    or
  • remove explicit references to sip altogether

See also downstream issue,
https://bugzilla.redhat.com/show_bug.cgi?id=1752766

@rdieter
Copy link
Author

rdieter commented Oct 2, 2019

@andreikop
Copy link
Owner

I do not support the tests now, because there are a lot of hard-to-track infrastructure problems and the tests consume much more time than save.

@rapgro
Copy link

rapgro commented Nov 23, 2019

As tests/base.py is considered, I can't build a new package in Fedora without disabling execution of nearly all tests.

@andreikop
Copy link
Owner

@rapgro, just disable the tests. They are not supposed to be run automatically now.
I haven't deleted the tests because sometimes run it manually, but supporting infrastructure for automatic run takes more time than saves because there are many unexpected problems on various platforms.

@rapgro
Copy link

rapgro commented Nov 24, 2019

Please, don't drop the tests. If they've any sense you should keep with them. That's how TDD should work. Maybe we can drop some difficult platforms then and instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants