Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very slow and infinite cycle. Use it in xaml #6

Closed
VadyaVL opened this issue Feb 22, 2018 · 5 comments
Closed

Very slow and infinite cycle. Use it in xaml #6

VadyaVL opened this issue Feb 22, 2018 · 5 comments
Labels
bug Something isn't working enhancement New feature or request resolved Waiting for validation

Comments

@VadyaVL
Copy link

VadyaVL commented Feb 22, 2018

Hello. I'm using a not very complicated template. However, your component is running slowly with it.
I would like to see the possibility of easy use in xaml (without CardViewItemFactory, use DataTemplate).
Also, when we initialize an empty list, we have an infinite loop (see CardsView.cs line 1066).
if index = 0 and _itemsCount = 0
0 >= 0
0 -= 0
........ infinite

@AndreiMisiukevich
Copy link
Owner

As for first remark.. DataTemplate just creates Views, with this, we will lose ability to cache views

As for second - I will check it

@AndreiMisiukevich AndreiMisiukevich added bug Something isn't working enhancement New feature or request labels Feb 22, 2018
@AndreiMisiukevich
Copy link
Owner

@VadyaVL haha) it's my bad, that I haven't implemented view creator via DataTemplate)
I overthought in this case, but you opened my eyes)

Thanks!

AndreiMisiukevich added a commit that referenced this issue Feb 23, 2018
@AndreiMisiukevich
Copy link
Owner

Check 1.2.9 version pls

@AndreiMisiukevich AndreiMisiukevich added the resolved Waiting for validation label Feb 23, 2018
@AndreiMisiukevich
Copy link
Owner

AndreiMisiukevich commented Feb 23, 2018

@VadyaVL Have you already checked it?)

@AndreiMisiukevich
Copy link
Owner

@VadyaVL if you like this package, please, set star on this repository) I will be grateful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request resolved Waiting for validation
Projects
None yet
Development

No branches or pull requests

2 participants