Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Status and StatusChanged event #4

Closed
LeoJHarris opened this issue Nov 21, 2018 · 5 comments
Closed

Add Status and StatusChanged event #4

LeoJHarris opened this issue Nov 21, 2018 · 5 comments
Labels
enhancement New feature or request

Comments

@LeoJHarris
Copy link

Hi great piece of control, question or enhancement is it possible to be notified when the expandable View is fully open and showing the secondary window. I want to run a task in the secondary view once it is fully open but right now while the secondary view is opening its freezing/slowing the UI while the secondary view is opening

@AndreiMisiukevich AndreiMisiukevich added the enhancement New feature or request label Nov 21, 2018
@AndreiMisiukevich
Copy link
Owner

AndreiMisiukevich commented Nov 21, 2018

Hi, obviously, there are several possible tricks/workarounds for achieving it) (like comparing secondaryView heigh with expected height or awaiting some delay etc)
But I think, we should create proper pretty way :)

Now we have only IsExpandChanged event.
I am keen to extend the view with

  1. IsExpandChangedCommand
  2. Status property (Opened, Closed, Opening, Closing)
  3. StatusChanedEvent
  4. StatusChangedCommand

What do you think ?

@LeoJHarris
Copy link
Author

LeoJHarris commented Nov 21, 2018

Hey I think StatusChangedEvent be best. Notify the subscriber when Opened, Closed, Opening and closing.

At this stage IsExpandChanged is called in the beginning stage of opening or closing but like the Rg.Plugins.Popup plugin that has OnAppearingAnimationEndAsync that can be overridden after page appeared. We should have a event that after secondary view is Appeared / open or Disappeared / closed in additions to opening and closing. Work is better delegated after the view is visible then during the opening phase

@AndreiMisiukevich
Copy link
Owner

I think, if we add StatusChangedEvent, we will be able to remove IsExpandedChanged as it will be redundant

@LeoJHarris
Copy link
Author

StatusChangedEvent replaces IsExpandedChanged. 👍 With 4 possible status's

@AndreiMisiukevich AndreiMisiukevich changed the title Expandable DidOpen Event? Add Status and StatusChanged event Nov 21, 2018
@AndreiMisiukevich
Copy link
Owner

1.0.2 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants