Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printer sometimes misprints "J" as the first letter of a label #18

Closed
sabeechen opened this issue Feb 17, 2023 · 1 comment · Fixed by #19
Closed

Printer sometimes misprints "J" as the first letter of a label #18

sabeechen opened this issue Feb 17, 2023 · 1 comment · Fixed by #19
Milestone

Comments

@sabeechen
Copy link
Contributor

The printer will sometimes print "J" incorrectly as the first letter of a print. After some debugging I've identified it happens any time the previous print ends with the same letter that the following print starts with. for example printing "HI THERE" followed by "EARTH" will result in "HI THERE" being correctly printed but then "JARTH".

This appears to be because the printer uses the "prevChar" variable to avoid moving the carousel between sequential identical letters. It doesn't get reset during a home, so the when the printer homes at the start of a print and moves to "J" prev char is still set to the last letter of the previous print.

Its a simple fix, I'll make a PR.

@andreisperid
Copy link
Owner

You solved the most annoying bug, thank you @sabeechen ! 👏

Duplicate of #1

@andreisperid andreisperid added this to the v1.0.1 milestone May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants