Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docClose issue on iPad #41

Closed
DanielM-1993 opened this issue Apr 25, 2016 · 9 comments
Closed

docClose issue on iPad #41

DanielM-1993 opened this issue Apr 25, 2016 · 9 comments
Assignees
Labels

Comments

@DanielM-1993
Copy link

DanielM-1993 commented Apr 25, 2016

Hello,

I have implemented your simple lightbox for use on a responsive and mobile friendly website however I am having problems with the docClose functionality when testing on an iPad. I have tested the functionality on an Android mobile, Windows 7 PC, Windows 10 PC and Macbook and for all of these clicking away from the image in the lightbox will cause it to close like expected however this functionality is not working for me on an iPad.

Are there any suggestions?

Note: I am running iOS 9.3.1 and using Safari

Update: I have noticed that you can close the lightbox if you click on the border between the image and the overlay but it has to be directly on the border, any further away and the functionality is lost.

@DanielM-1993 DanielM-1993 changed the title docClose on iPad docClose issue on iPad Apr 25, 2016
@andreknieriem
Copy link
Owner

Hey thanks for feedback. Will try to find a bugfix for it. Does clicking on the overlay work?

@andreknieriem andreknieriem self-assigned this Apr 26, 2016
@DanielM-1993
Copy link
Author

DanielM-1993 commented Apr 27, 2016

Clicking the overlay on a Windows dekstop, laptop or Macbook works. So does clicking the overlay on an Android mobile/tablet. iPad is the only one where clicking the overlay doesn't work. I haven't been able to test an iPhone sadly but this may have the same issue.

@andreknieriem
Copy link
Owner

Hey, does everything else work? For example next/prev Buttons and so on? I only can test it on an old ipad 3 in the next days, but I can't imagine what the problem is.

@DanielM-1993
Copy link
Author

DanielM-1993 commented Apr 28, 2016

Yeah, navigation buttons work fine. I've read that iOS/Safari doesn't register click events in the same way that everything else does. It might be a similar issue.

Update: I have also tried to touch the overlay to close the lightbox in Google Chrome for iOS and it has the same issue as Safari for iOS. I have a feeling it's something to do with how iOS registers touches.

@andreknieriem
Copy link
Owner

Changed something in the code. Could see the preview here:

http://andreknieriem.de/simple-lightbox-dev/ Please check it out with your iOS Device.

@DanielM-1993
Copy link
Author

DanielM-1993 commented Apr 29, 2016

I've had a look at the preview in Google Chrome and Safari on the iPad again and the touch overlay to close functionality is still not working. May I ask what solution you tried?

Also tried this functionality on Windows 7 in Google Chrome and Android Phone in Chrome and the overlay works for both of those. Definitely an issue with iOS :(

@andreknieriem
Copy link
Owner

andreknieriem commented May 2, 2016

So on my iPhone it works now. Can you please check it on my dev page:
http://andreknieriem.de/simple-lightbox-dev/

Best regards

@andreknieriem
Copy link
Owner

I close this issue. If it still doesn't work for you, please let me know.

@DanielM-1993
Copy link
Author

Works perfectly! Thank you very much for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants