Darcula theme in IntelliJ 12 - problem with readability #29

GoogleCodeExporter · 2015-04-23T09:15:43Z

What steps will reproduce the problem?
1. Analyze code in IntelliJ 12 with Darcula color theme
2. Setup FindBug in Settings - check buttons, Advanced mode
3. Highlight error in source code make the code unreadable

What is the expected output? What do you see instead?
integrate plugin to use Darcula theme

What version of the product are you using? On what operating system?
0.9.97, Windows XP

Please provide any additional information below.

Original issue reported on code.google.com by kalita.d...@gmail.com on 15 Mar 2013 at 9:50

The text was updated successfully, but these errors were encountered:

GoogleCodeExporter · 2015-04-23T09:15:44Z

Also "FindBugs-IDEA Findbugs Analysis Results" have low usability as in 
"hurting my eyes" when Dracula theme is enabled. Problem is, that textareas 
have white background which just screams out from otherwise calm dark-ish 
product. (see attached image)

Original comment by lauri.va...@gmail.com on 18 Apr 2013 at 1:36

Attachments:

findbugs-dracula.png

GoogleCodeExporter · 2015-04-23T09:15:44Z

Same here, I am using Darcula on Linux. A lot of stuff is barely readable, e.g. 
findbug findings have a black foreground font on dark grey background. Please 
make it configurable or adapt it somehow to the current theme settings.

Original comment by andreas....@gmail.com on 2 May 2013 at 3:34

GoogleCodeExporter · 2015-04-23T09:15:44Z

findbug results have a black foreground font on black background with theme 
Dracula. not able to check code for the bugs

Original comment by zhengs...@gmail.com on 21 May 2013 at 10:04

GoogleCodeExporter · 2015-04-23T09:15:44Z

Fix it, pleeeeeeeeeeeeeeeeeeeeease

Original comment by kornero...@gmail.com on 28 May 2013 at 6:59

GoogleCodeExporter · 2015-04-23T09:15:45Z

[deleted comment]

GoogleCodeExporter · 2015-04-23T09:15:45Z

It is a problem for me as well.

Original comment by johndw...@gmail.com on 18 Jun 2013 at 6:33

GoogleCodeExporter · 2015-04-23T09:15:45Z

Pls fix it ASAP, it kills my eyes

Original comment by caterzy on 5 Aug 2013 at 2:55

GoogleCodeExporter · 2015-04-23T09:15:45Z

Issue 37 has been merged into this issue.

Original comment by andre.pf...@gmail.com on 26 Aug 2013 at 1:37

GoogleCodeExporter · 2015-04-23T09:15:45Z

Original comment by andre.pf...@gmail.com on 26 Aug 2013 at 1:38

Changed state: Accepted

GoogleCodeExporter · 2015-04-23T09:15:45Z

Fixed in the released version 0.9.98 (rev. #218).

Original comment by reto.merz@gmail.com on 28 Aug 2013 at 11:27

Changed state: Fixed

GoogleCodeExporter · 2015-04-23T09:15:46Z

Fixed in 0.9.98? What exactly did you fix? It is still not readable. See 
attached screenshot

Original comment by andreas....@gmail.com on 29 Aug 2013 at 9:48

Attachments:

[Screenshot from 2013-08-29 11:45:43.png](https://storage.googleapis.com/google-code-attachments/findbugs-idea/issue-29/comment-11/Screenshot from 2013-08-29 11:45:43.png)

GoogleCodeExporter · 2015-04-23T09:15:46Z

[deleted comment]

GoogleCodeExporter · 2015-04-23T09:15:46Z

> What exactly did you fix?

what exactly are looking on ? 

compare your two screenshot and see the diff "problem is, that textareas have 
white background" . its not ideally but darker ;) feel free to provide a 
'color' patch or switch your theme

whats your expectation? give a usefull  suggestion instead...such comment.

Original comment by andre.pf...@gmail.com on 29 Aug 2013 at 10:02

GoogleCodeExporter · 2015-04-23T09:15:46Z

Is it possible to get color just from the theme? Because, I'm using my own 
custom dark theme. I thinks it is not a good practice to inline color constants 
just in source code.

Original comment by kornero...@gmail.com on 29 Aug 2013 at 10:06

GoogleCodeExporter · 2015-04-23T09:15:46Z

I am talking about the same issues, everyone else here is complaining about. 
Findbugs errors are black on dark grey background, nearly impossible to read 
(see the java efitor in my screenshot). There are other parts of the screenshot 
that have the same problems (dark colored fonts with dark background)
You are ignoring this bug for a long time now, there are 20! People watching 
this bug. It's true that this is open source, so its up to you if you care 
about your users or not and if you want to fix this bug or not. 
But if you don't have the time to fix this bug, then for god's sake, have the 
guts to say it and don't tell us you've fixed something that's not fixed!

Original comment by andreas....@gmail.com on 29 Aug 2013 at 10:10

GoogleCodeExporter · 2015-04-23T09:15:46Z

your are right. but those comments like " What exactly did you fix? It is still 
not readable." are rubbish. he should always keep in mind that we'Re working on 
the plugin in our spare time for the community - the commenter could be a 
little more

Original comment by andre.pf...@gmail.com on 29 Aug 2013 at 10:12

GoogleCodeExporter · 2015-04-23T09:15:47Z

the readability is much better than before as already mentioned ... not ideally 
but better. anyways reopened and patches are welcome.

Original comment by andre.pf...@gmail.com on 29 Aug 2013 at 10:15

Changed state: Started

GoogleCodeExporter · 2015-04-23T09:15:47Z

I am not a native english speaker as well, so I apologize if this comment 
sounded too harsh. But I was truly asking about the details of the fix, not 
just complaining. I tried sevral things, like switching the theme, restarting 
intellij etc. and I couldn't find a single thing that got better in release 
0.9.98. So I am asking again politely: what did you fix that got better in the 
new release for darcula users?

Original comment by andreas....@gmail.com on 29 Aug 2013 at 10:19

GoogleCodeExporter · 2015-04-23T09:15:47Z

[deleted comment]

GoogleCodeExporter · 2015-04-23T09:15:47Z

as i wrote before... "whats your expectation? give a usefull  suggestion 
instead" and compare those two screenshot in this thread. i see a difference in 
those ones

Original comment by andre.pf...@gmail.com on 29 Aug 2013 at 10:24

GoogleCodeExporter · 2015-04-23T09:15:47Z

and keep in minde, there were other fixes with a much more higher prio than any 
layout/ui stuff.

Original comment by andre.pf...@gmail.com on 29 Aug 2013 at 10:26

GoogleCodeExporter · 2015-04-23T09:15:47Z

I feel like i can contribute this (flame like) dialog.
I just took a look at the new screenshot, and it indeed improves a lot on the 
first screenshot. If the first was painful to look at in dimply lighted room, 
then the new one is absolutely better on that front.
However, current issue is more broad that only the screenshot i posted.
I believe that original problem for original reporter was related to "3. 
Highlight error in source code make the code unreadable", which probably means 
that text and background don't have enough contrast.
The second screenshot has indeed darkened background on textareas, but the text 
in there is not always readable.
For example "fillStrings" and whatever comes after it, is practically invisible 
on my screen.

So far the suggestion to get background and text colors from selected theme is 
about the best. Because you will never know, when someone has configured nice 
blue background to his editor (in true "Norton Commander" or "Blue Screen of 
Death" style) and when you render some text (maybe links or something like 
that) in blue color, then those would be truly hard to spot.

If you get background and foreground colors from theme, then you are on the 
safe side. It does get trickier when you want to color code different texts, 
but for these occasions theme must have some other defined text colors as well 
-- how else they would do their java highlighting.

Hope that helps.

Original comment by lauri.va...@gmail.com on 29 Aug 2013 at 10:38

GoogleCodeExporter · 2015-04-23T09:15:48Z

yeah. flame war end. i just switched to the dark theme and antoher really big 
problem is. the Bugannotator highlighter which darks all text.

exactly "Highlight error in source code make the code unreadable","  this is 
really annoying

Original comment by andre.pf...@gmail.com on 29 Aug 2013 at 10:45

GoogleCodeExporter · 2015-04-23T09:15:48Z

I can see only one diff - white rectangle in the right corner.
But for me, it really not makes huge diff. The main problem (for me) is a black 
font. I simply can't see java code at all. Because I have dark background, and 
I have black text. So I can't use your plugin at all, because I can't see my 
code :-(

Of course, I understand you, I understand that you are doing it for free. If I 
were you, I would better spend my own time with my family, not with a strange 
guys who are writting some bug-reports about font colors))) 

I just want to say, that this ticket is about java code readability and it is 
the main problem.

P.S. Sorry for my bad english.

Anyway, big thanks that you are doing it ;-)

Original comment by kornero...@gmail.com on 29 Aug 2013 at 10:47

GoogleCodeExporter · 2015-04-23T09:15:48Z

Suggestions are: get rid of black on dark grey fonts like the error in the java 
editor. Get rid of light grey on light yellow. Get rid of green on dark grey. 
All these combinations are terrible to read and that's what people are 
complaining about. Why not creating two color schemes, one for light and one 
for dark background. Let people switch between them. That's what I would 
probably do. 
I fully understand that this takes time to implement and that bugs need to be 
prioritized. We already waited several months for a fix and we would wait some 
more time. We all probably work at least partially on open source projects, so 
we we all know this situation. 
Just don't close bugs that are not fixed just to get rid of bad bug statistics. 
As I said, we will wait...

Original comment by andreas....@gmail.com on 29 Aug 2013 at 10:48

GoogleCodeExporter · 2015-04-23T09:15:48Z

Original comment by andre.pf...@gmail.com on 29 Aug 2013 at 12:18

Added labels: Component-UI, Usability

GoogleCodeExporter · 2015-04-23T09:15:48Z

...looks better....

Original comment by andre.pf...@gmail.com on 30 Aug 2013 at 3:31

Attachments:

cache7.png

GoogleCodeExporter · 2015-04-23T09:15:48Z

I have a small patch to help fix this issue - especially for the settings panel.

Original comment by si...@billingsley.me.uk on 1 Sep 2013 at 5:15

Attachments:

Issue_29_-_Darcula_Readability.patch

GoogleCodeExporter · 2015-04-23T09:15:48Z

thanks, patch applied with r234

Original comment by andre.pf...@gmail.com on 2 Sep 2013 at 8:51

GoogleCodeExporter · 2015-04-23T09:15:49Z

next release (hopefully this week) will contain all the theming changes. 
preview @see #27


sneak-preview: 
https://code.google.com/p/findbugs-idea/downloads/detail?name=FindBugs-IDEA-0.9.
98.236.zip

feedback is always welcome.

Original comment by andre.pf...@gmail.com on 2 Sep 2013 at 9:51

Changed state: Fixed

GoogleCodeExporter · 2015-04-23T09:15:49Z

[deleted comment]

GoogleCodeExporter · 2015-04-23T09:15:49Z

[deleted comment]

GoogleCodeExporter · 2015-04-23T09:15:49Z

Hi,
Once I noticed that this issue  has been marked fixed, I have installed the 
plugin again. 

But I still see the black on black problem: (see screenshot)
http://i.snag.gy/i09ul.jpg

maybe I am missing something. Can somebody advice, what do I need to change, to 
get the right UI colors for findbugs plugin?

Original comment by hus...@gmail.com on 27 Sep 2013 at 1:30

GoogleCodeExporter · 2015-04-23T09:15:49Z

Please provide US with the Plugin Version you use

Original comment by andre.pf...@gmail.com on 27 Sep 2013 at 8:39

GoogleCodeExporter · 2015-04-23T09:15:49Z

Hi,

the version I have is 0.9.99.

and this is the screenshot:
http://i.snag.gy/i09ul.jpg

Thanks

Original comment by hus...@gmail.com on 27 Sep 2013 at 5:18

GoogleCodeExporter · 2015-04-23T09:15:50Z

Hi,

I also have a problem with black text on dark background. Plugin version 
0.9.98, from the repository, IDEA 13. The code is completely unreadable.

Why change font color for warnings at all? Are underlines not enough?

Original comment by dpx.infinity@gmail.com on 4 Dec 2013 at 9:47

Attachments:

Capture.PNG

GoogleCodeExporter · 2015-04-23T09:15:50Z

Original comment by pfei...@e-spirit.com on 4 Dec 2013 at 10:01

Changed state: Started

GoogleCodeExporter · 2015-04-23T09:15:50Z

please check out version 0.9.991 in downloads and later in idea plugin 
repository

Original comment by andre.pf...@gmail.com on 4 Dec 2013 at 11:17

GoogleCodeExporter · 2015-04-23T09:15:50Z

http://plugins.jetbrains.com/update/index?pr=idea&updateId=14730

Original comment by andre.pf...@gmail.com on 4 Dec 2013 at 11:21

GoogleCodeExporter · 2015-04-23T09:15:50Z

feedback is very welcome

http://plugins.jetbrains.com/update/index?pr=idea&updateId=14730

Original comment by andre.pf...@gmail.com on 4 Dec 2013 at 11:21

GoogleCodeExporter · 2015-04-23T09:15:50Z

Original comment by andre.pf...@gmail.com on 4 Dec 2013 at 12:35

Added labels: Priority-High
Removed labels: Priority-Medium

GoogleCodeExporter · 2015-04-23T09:15:50Z

Issue 45 has been merged into this issue.

Original comment by andre.pf...@gmail.com on 4 Dec 2013 at 1:31

GoogleCodeExporter · 2015-04-23T09:15:51Z

Issue 42 has been merged into this issue.

Original comment by andre.pf...@gmail.com on 4 Dec 2013 at 1:35

GoogleCodeExporter · 2015-04-23T09:15:51Z

It is SO much better now! Thank you very much!

Original comment by dpx.infinity@gmail.com on 4 Dec 2013 at 2:16

Attachments:

Capture.PNG

GoogleCodeExporter · 2015-04-23T09:15:51Z

Good job, guys! very good now...

Original comment by andreas....@gmail.com on 5 Dec 2013 at 1:29

GoogleCodeExporter · 2015-04-23T09:15:51Z

could we close this issue right now? does dark theme looks ok?

Original comment by pfei...@e-spirit.com on 16 Jan 2014 at 4:20

GoogleCodeExporter · 2015-04-23T09:15:51Z

+1 to close.  Looks good here.  Thanks for your efforts.

Original comment by ryan.lu...@gmail.com on 16 Jan 2014 at 11:23

GoogleCodeExporter · 2015-04-23T09:15:51Z

Original comment by reto.merz@gmail.com on 23 Feb 2014 at 6:32

Changed state: Fixed

GoogleCodeExporter · 2015-04-23T09:15:51Z

old issues - verified -> change state to done

Original comment by andre.pf...@gmail.com on 19 Mar 2014 at 2:20

Changed state: Done

GoogleCodeExporter · 2015-04-23T09:15:52Z

change state to verified.

Original comment by andre.pf...@gmail.com on 19 Mar 2014 at 2:21

Changed state: Verified

GoogleCodeExporter added Type-Defect auto-migrated Usability Component-UI Priority-High labels Apr 23, 2015

GoogleCodeExporter closed this as completed Apr 23, 2015

This was referenced Apr 23, 2015

Make the plugin aware of the default themes included with Intellij - particularly Darkula #37

Closed

NullPointerException #42

Closed

ModuleRootManager must not be null. may be the current class is not a project/module class. #45

Closed

Darcula theme in IntelliJ 12 - problem with readability #29

Darcula theme in IntelliJ 12 - problem with readability #29

Comments

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015

GoogleCodeExporter commented Apr 23, 2015