Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math-magicians Milestone 1: Setup #1

Merged
merged 6 commits into from Feb 8, 2022
Merged

Math-magicians Milestone 1: Setup #1

merged 6 commits into from Feb 8, 2022

Conversation

andres-condezo
Copy link
Owner

Math-magicians Milestone 1: Setup

Hi there πŸ‘‹

Thanks for taking the time to review my project.


Get Started

Visit live demo :
β€’ Math Magician Live Demo Link

or:

Clone the repository :
β€’ $ git clone https://github.com/andres-condezo/math-magicians.git
β€’ $ git checkout setup
β€’ $ npm install
β€’ $ npm start


Changes

In this milestone I:

  • Set up a React app.

Any comment or suggestion will be thankfully received.

Copy link

@Cathella Cathella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ”₯ Status: Approved 🟒

Hi @andres-condezo πŸ‘‹πŸ»,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! πŸŽ‰

To Highlight πŸ’ͺ🏻

βœ… No linter errors.
βœ… You used correct Github Flow.
βœ… Professional README.
βœ… The app is created with Create React App

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@andres-condezo andres-condezo merged commit e8237a4 into main Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants