Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math-magicians Milestone 2: Components #2

Merged
merged 12 commits into from Feb 10, 2022
Merged

Math-magicians Milestone 2: Components #2

merged 12 commits into from Feb 10, 2022

Conversation

andres-condezo
Copy link
Owner

@andres-condezo andres-condezo commented Feb 10, 2022

Math-magicians Milestone 2: Components

Hi there πŸ‘‹

Thanks for taking the time to review my project.


Get Started

Visit live demo :
β€’ Math Magician Live Demo Link

or:

Clone the repository :
β€’ $ git clone https://github.com/andres-condezo/math-magicians.git
β€’ $ cd math-magicians
β€’ $ git checkout components
β€’ $ npm install
β€’ $ npm start


Changes

In this milestone:

  • I deleted all the boilerplate from CRA.
  • I created a directory called components and created a new Calculator.js file.
  • In Calculator.js, I created a React component that matches the original design using class-based components.
  • I developed the calculator UI.

Any comment or suggestion will be thankfully received.

Copy link

@arslanbisharat arslanbisharat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved πŸ‘

Hi there,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! πŸŽ‰

To Highlight:

  • The Pull Request has a proper title and description. βœ”οΈ
  • You have added a descriptive Readme file. Good Job. βœ”οΈ
  • There is no linter error is present. βœ”οΈ
  • Project has met all the technical aspects you needed for this project. Keep rocking! βœ”οΈ

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of code reviews per project which you can see from your dashboard. If you think that the code review was not fair, you can request a second opinion using this form

@andres-condezo andres-condezo merged commit 76443a5 into dev Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants